ChromeOS: enable SystemTimezoneAutomaticDetectionPolicy by default.

ChromeOS: enable SystemTimezoneAutomaticDetectionPolicy by default.

This Cl enables SystemTimezoneAutomaticDetectionPolicy by default.

BUG=575732
TEST=none

Committed: https://crrev.com/b1109d34016ca5df91f7341f69fe371a194def46
Cr-Commit-Position: refs/heads/master@{#400530}

[Alexander Alekseev, 2016-06-04 05:03:37]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-04 05:03:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031303003/1

[Alexander Alekseev, 2016-06-04 05:13:21]

alemate@chromium.org changed reviewers:
+ bartfab@chromium.org, isherman@chromium.org, xiyuan@chromium.org

[Alexander Alekseev, 2016-06-04 05:13:22]

Please review:

xiyuan@ :
  chromeos/chromeos_switches.cc
  chromeos/chromeos_switches.h
  c/b/c/system/timezone_resolver_manager.cc
  c/b/ui/webui/options/browser_options_handler.cc 


bartfab@:
  c/b/policy/policy_browsertest.cc 

isherman@
  tools/metrics/histograms/histograms.xml

[Ilya Sherman, 2016-06-04 05:20:46]

histograms.xml lgtm

[commit-bot: I haz the power, 2016-06-04 06:11:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-04 06:11:41]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-06-04 14:36:19]

https://codereview.chromium.org/2031303003/diff/1/chromeos/chromeos_switches.cc
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/2031303003/diff/1/chromeos/chromeos_switches....
chromeos/chromeos_switches.cc:372: "enable-system-timezone-automatic-detection";
Actual value needs to be updated too.

[Alexander Alekseev, 2016-06-06 21:06:15]

https://codereview.chromium.org/2031303003/diff/1/chromeos/chromeos_switches.cc
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/2031303003/diff/1/chromeos/chromeos_switches....
chromeos/chromeos_switches.cc:372: "enable-system-timezone-automatic-detection";
On 2016/06/04 14:36:19, xiyuan wrote:
> Actual value needs to be updated too.

Done.

[xiyuan, 2016-06-06 21:09:46]

lgtm

[bartfab (slow), 2016-06-16 20:07:54]

Is this the first time the policy will actually be available on production
Chromebooks? If so, the range of supported versions in policy_templates.json
should be updated. It currently claims that this policy is available from M51
onward.

Other than that, lgtm.

https://codereview.chromium.org/2031303003/diff/20001/chromeos/chromeos_switc...
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/2031303003/diff/20001/chromeos/chromeos_switc...
chromeos/chromeos_switches.cc:370: // This flag enables
SystemTimezoneAutomaticDetection policy.
Nit: s/enables/disables/

[Alexander Alekseev, 2016-06-17 10:51:17]

https://codereview.chromium.org/2031303003/diff/20001/chromeos/chromeos_switc...
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/2031303003/diff/20001/chromeos/chromeos_switc...
chromeos/chromeos_switches.cc:370: // This flag enables
SystemTimezoneAutomaticDetection policy.
On 2016/06/16 20:07:54, bartfab (slow) wrote:
> Nit: s/enables/disables/

Done.

[Alexander Alekseev, 2016-06-17 10:51:43]

On 2016/06/16 20:07:54, bartfab (slow) wrote:
> Is this the first time the policy will actually be available on production
> Chromebooks? If so, the range of supported versions in policy_templates.json
> should be updated. It currently claims that this policy is available from M51
> onward.
> 
> Other than that, lgtm.

I updated policy templates.

[Alexander Alekseev, 2016-06-17 10:52:00]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-06-17 10:52:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, bartfab@chromium.org, xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2031303003/#ps60001
(title: "Comment updated.")

[commit-bot: I haz the power, 2016-06-17 10:52:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031303003/60001

[commit-bot: I haz the power, 2016-06-17 10:58:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 10:58:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alexander Alekseev, 2016-06-17 11:11:29]

alemate@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Alexander Alekseev, 2016-06-17 11:11:30]

+stevenjb@ : Please review:
  chrome/browser/ui/webui/options/browser_options_handler.cc

[stevenjb, 2016-06-17 17:00:23]

lgtm

[Alexander Alekseev, 2016-06-17 22:37:58]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-06-17 22:38:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031303003/60001

[commit-bot: I haz the power, 2016-06-17 22:43:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-17 22:45:42]

Description was changed from

==========
ChromeOS: enable SystemTimezoneAutomaticDetectionPolicy by default.

This Cl enables SystemTimezoneAutomaticDetectionPolicy by default.

BUG=575732
TEST=none
==========

to

==========
ChromeOS: enable SystemTimezoneAutomaticDetectionPolicy by default.

This Cl enables SystemTimezoneAutomaticDetectionPolicy by default.

BUG=575732
TEST=none

Committed: https://crrev.com/b1109d34016ca5df91f7341f69fe371a194def46
Cr-Commit-Position: refs/heads/master@{#400530}
==========

[commit-bot: I haz the power, 2016-06-17 22:45:43]

Patchset 4 (id:??) landed as
https://crrev.com/b1109d34016ca5df91f7341f69fe371a194def46
Cr-Commit-Position: refs/heads/master@{#400530}