Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: build/java.gypi

Issue 20313002: Avoid too long command lines. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed the file extension to .gypcmd Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/java.gypi
diff --git a/build/java.gypi b/build/java.gypi
index ec8431b92da2e05417a7e716c1eb0d9ad2b69435..1635c71da40db66cfee1a1737cc9089057ec378c 100644
--- a/build/java.gypi
+++ b/build/java.gypi
@@ -153,6 +153,10 @@
# resources in dependencies can be resolved.
'all_res_dirs': ['<@(res_input_dirs)',
'>@(dependencies_res_input_dirs)',],
+ # Write the inputs list to a file, so that the action command
+ # line won't exceed the OS limits when calculating the checksum
+ # of the list.
+ 'inputs_list_file': '>|(inputs_list.<(_target_name).gypcmd >@(_inputs))'
},
'inputs': [
'<(DEPTH)/build/android/gyp/util/build_utils.py',
@@ -179,7 +183,7 @@
# Add hash of inputs to the command line, so if inputs change
# (e.g. if a resource if removed), the command will be re-run.
# TODO(newt): remove this once crbug.com/177552 is fixed in ninja.
- '--ignore=>!(echo \'>(_inputs)\' | md5sum)',
+ '--ignore=>!(md5sum >(inputs_list_file))',
],
},
# Generate API 14 resources.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698