Issue 2031293002: Don't crash when tree shaking is disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2031293002: Don't crash when tree shaking is disabled (Closed)

Created:
4 years, 6 months ago by Johnni Winther

Modified:
4 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang), Harry Terkelsen

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't crash when tree shaking is disabled When tree shaking is disabled, type checking crashed on member lookup into serialized classes. Also classes are now ensured to be resolved when computing lookup. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/153c36ce3994f46913eea77346e19cb2f90192db

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -0 lines)			Patch
M	pkg/compiler/lib/src/resolution/class_members.dart	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/serialization/model_test.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/serialization/test_data.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

4 years, 6 months ago (2016-06-06 09:08:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
153c36ce3994f46913eea77346e19cb2f90192db (presubmit successful).