Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2031243002:
Disable tables/mozilla/bugs/bug30692.html on Mac10.11 (Closed)
|
Created:
4 years, 6 months ago by vabr (Chromium) Modified:
4 years, 6 months ago Reviewers:
Gleb Lanbin CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable tables/mozilla/bugs/bug30692.html on Mac10.11
The test fails on Mac 10.11 after auto-rebaseline, see the bug for more info.
TBR=glebl@chromium.org
BUG=617033
Added NOTRY, because there is a lot of other breakage in Blink currently.
NOTRY=true
Committed: https://crrev.com/98bb6267e7954dde9082785b792bdcf815d51c30
Cr-Commit-Position: refs/heads/master@{#397682}
Patch Set 1 #Patch Set 2 : Rebased #Patch Set 3 : Rebase and also move the diff up the file to avoid clashes with auto-rebaseline changes #Messages
Total messages: 26 (13 generated)
The CQ bit was checked by vabr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031243002/1
lgtm
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1337 Falling back to three-way merge... Applied patch to 'third_party/WebKit/LayoutTests/TestExpectations' with conflicts. U third_party/WebKit/LayoutTests/TestExpectations Patch: third_party/WebKit/LayoutTests/TestExpectations Index: third_party/WebKit/LayoutTests/TestExpectations diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations index a81eda0d0906bf7fa45a588ac538089031de3483..36856d91b883a55cdbe0f9ecf38e0b27befd46df 100644 --- a/third_party/WebKit/LayoutTests/TestExpectations +++ b/third_party/WebKit/LayoutTests/TestExpectations @@ -1337,3 +1337,6 @@ crbug.com/613661 imported/wpt/quirks-mode/table-cell-nowrap-minimum-width-calcul crbug.com/613663 imported/wpt/quirks-mode/table-cell-width-calculation.html [ Failure ] crbug.com/614509 [ Win ] inspector/elements/styles-2/pseudo-elements.html [ Pass Timeout ] + +# Failed expectation after auto-rebaseline. +crbug.com/617033 [ Mac10.11 ] tables/mozilla/bugs/bug30692.html [ Failure ]
The CQ bit was unchecked by commit-bot@chromium.org
Rebased
The CQ bit was checked by vabr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from glebl@chromium.org Link to the patchset: https://codereview.chromium.org/2031243002/#ps20001 (title: "Rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031243002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Rebase and also move the diff up the file to avoid clashes with auto-rebaseline changes
The CQ bit was checked by vabr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from glebl@chromium.org Link to the patchset: https://codereview.chromium.org/2031243002/#ps40001 (title: "Rebase and also move the diff up the file to avoid clashes with auto-rebaseline changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031243002/40001
Description was changed from ========== Disable tables/mozilla/bugs/bug30692.html on Mac10.11 The test fails on Mac 10.11 after auto-rebaseline, see the bug for more info. TBR=glebl@chromium.org BUG=617033 ========== to ========== Disable tables/mozilla/bugs/bug30692.html on Mac10.11 The test fails on Mac 10.11 after auto-rebaseline, see the bug for more info. TBR=glebl@chromium.org BUG=617033 Added NOTRY, because there is a lot of other breakage in Blink currently. NOTRY=true ==========
The CQ bit was unchecked by vabr@chromium.org
The CQ bit was checked by vabr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031243002/40001
Message was sent while issue was closed.
Description was changed from ========== Disable tables/mozilla/bugs/bug30692.html on Mac10.11 The test fails on Mac 10.11 after auto-rebaseline, see the bug for more info. TBR=glebl@chromium.org BUG=617033 Added NOTRY, because there is a lot of other breakage in Blink currently. NOTRY=true ========== to ========== Disable tables/mozilla/bugs/bug30692.html on Mac10.11 The test fails on Mac 10.11 after auto-rebaseline, see the bug for more info. TBR=glebl@chromium.org BUG=617033 Added NOTRY, because there is a lot of other breakage in Blink currently. NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Disable tables/mozilla/bugs/bug30692.html on Mac10.11 The test fails on Mac 10.11 after auto-rebaseline, see the bug for more info. TBR=glebl@chromium.org BUG=617033 Added NOTRY, because there is a lot of other breakage in Blink currently. NOTRY=true ========== to ========== Disable tables/mozilla/bugs/bug30692.html on Mac10.11 The test fails on Mac 10.11 after auto-rebaseline, see the bug for more info. TBR=glebl@chromium.org BUG=617033 Added NOTRY, because there is a lot of other breakage in Blink currently. NOTRY=true Committed: https://crrev.com/98bb6267e7954dde9082785b792bdcf815d51c30 Cr-Commit-Position: refs/heads/master@{#397682} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/98bb6267e7954dde9082785b792bdcf815d51c30 Cr-Commit-Position: refs/heads/master@{#397682} |
