Issue 203123009: Disallow calling Map on currently-mapped SharedMemory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203123009: Disallow calling Map on currently-mapped SharedMemory (Closed)

Created:
6 years, 9 months ago by jbauman

Modified:
6 years, 9 months ago

Reviewers:

CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Disallow calling Map on currently-mapped SharedMemory This would leak the previous mapping of the memory. TBR=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257789

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -2 lines)			Patch
M	base/memory/shared_memory.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	base/memory/shared_memory_nacl.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	base/memory/shared_memory_posix.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	base/memory/shared_memory_unittest.cc	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	base/memory/shared_memory_win.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

jbauman

6 years, 9 months ago (2014-03-18 22:33:53 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r257789 (presubmit successful).