Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 203123006: Ignore V8's message handler that is invoked while we're initializing a window (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Ignore V8's message handler that is invoked while we're initializing a window messageHandlerInMainThread can be invoked while we're initializing a window (See stack traces in the bugs). In that half-baked situation, we don't have a valid context nor a valid world, so we should return immediately. BUG=345014, 352179 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/bindings/v8/V8Initializer.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
haraken
PTAL
6 years, 9 months ago (2014-03-18 18:10:10 UTC) #1
dcarney
lgtm
6 years, 9 months ago (2014-03-18 20:22:03 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-19 03:10:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/203123006/1
6 years, 9 months ago (2014-03-19 03:10:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 04:13:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-19 04:13:14 UTC) #6
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-19 04:20:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/203123006/1
6 years, 9 months ago (2014-03-19 04:20:42 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 04:21:00 UTC) #9
Message was sent while issue was closed.
Change committed as 169518

Powered by Google App Engine
This is Rietveld 408576698