Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2031223003: Support underline on Linux again. (Closed)

Created:
4 years, 6 months ago by Mikus
Modified:
4 years, 6 months ago
CC:
chromium-reviews, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support underline on Linux again. BUG=617055 https://codereview.chromium.org/1819753003/ accidentally removed UNDERLINE style support on Linux. This CL fixes the issue. Committed: https://crrev.com/fcf96463f4915f0a8f76619fcf1249ab0382d5a5 Cr-Commit-Position: refs/heads/master@{#398102}

Patch Set 1 #

Patch Set 2 : Fixed the gtk2_ui as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -41 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/font_list_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/font_render_params_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/linux_font_delegate.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gfx/platform_font_linux.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/platform_font_linux.cc View 11 chunks +21 lines, -22 lines 0 comments Download
M ui/gfx/platform_font_linux_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Mikus
4 years, 6 months ago (2016-06-03 10:35:38 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 6 months ago (2016-06-03 14:28:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031223003/20001
4 years, 6 months ago (2016-06-03 15:25:16 UTC) #5
Mikus
On 2016/06/03 14:28:30, Alexei Svitkine (slow) wrote: > lgtm alekseis - not that slow at ...
4 years, 6 months ago (2016-06-03 15:26:12 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 16:43:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031223003/20001
4 years, 6 months ago (2016-06-03 16:50:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/194801)
4 years, 6 months ago (2016-06-03 16:58:41 UTC) #12
tapted
(+erg) lgtm but you needs some libgtk2ui/OWNERS - erg?
4 years, 6 months ago (2016-06-06 02:41:05 UTC) #14
Elliot Glaysher
lgtm
4 years, 6 months ago (2016-06-06 16:21:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031223003/20001
4 years, 6 months ago (2016-06-06 18:15:39 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 19:54:58 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 19:56:06 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fcf96463f4915f0a8f76619fcf1249ab0382d5a5
Cr-Commit-Position: refs/heads/master@{#398102}

Powered by Google App Engine
This is Rietveld 408576698