Fix a bug with the Chrome legacy window at times becoming a top level window with a non functional …

Fix a bug with the Chrome legacy window at times becoming a top level window with a non functional button in the taskbar.

This bug typically occurs if the legacy window stays around after it is
removed from the original root window.

It looks like a recent change (https://codereview.chromium.org/1996163002)
which ensures that the legacy window is always created exacerbates this
problem by creating the legacy windows early and some of them stay around
after a tab switch. Typical cases include opening a pdf file in chrome
which causes at least two RWVHA instances to be active at any given point
and the legacy window which belongs to the original instance becomes a
button on the taskbar when the tab is switched.

Fix is to never reparent to the desktop window and instead always reparent
to the hidden window.

BUG=616410
Committed: https://crrev.com/b35c046639c244df4a954a791e24cfe7d5270daa
Cr-Commit-Position: refs/heads/master@{#397790}

[ananta, 2016-06-03 02:38:21]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-06-03 02:39:02]

LGTM - please add a test as well.

[ananta, 2016-06-03 02:40:03]

ananta@chromium.org changed reviewers:
+ ncarter@chromium.org

[ananta, 2016-06-03 02:40:03]

+ncarter for content owners

[ananta, 2016-06-03 02:40:53]

On 2016/06/03 02:39:02, sky wrote:
> LGTM - please add a test as well.

Will do it in a separate patch.

[ananta, 2016-06-03 02:41:21]

ananta@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[ananta, 2016-06-03 02:41:21]

+dmazzoni.

[dmazzoni, 2016-06-03 15:46:56]

lgtm, this seems good

I still think https://codereview.chromium.org/1987903002/
would be a better solution, because then we'd only be
creating the legacy window once per top-level window, not
every time there's a new RWHVA. We'd be able to eliminate
all of these timing issues. Please consider that change
after we land and merge this one.

[ncarter (slow), 2016-06-03 19:37:59]

Description was changed from

==========
Fix a bug with the Chrome legacy window at times becoming a top level window
with a non functional button in the taskbar.

This bug typically occurs if the legacy window stays around after it is
removed from the original root window.

It looks like a recent change (https://codereview.chromium.org/1996163002)
which ensures that the legacy window is always created exacerbates this
problem by creating the legacy windows early and some of them stay around
after a tab switch. Typical cases include opening a pdf file in chrome
which causes at least two RWVHA instances to be active at any given point
and the legacy window which belongs to the original instance becomes a
button on the taskbar when the tab is switched.

Fix is to never reparent to the desktop window and instead always reparent
to the hidden window.

BUG=616410
==========

to

==========
Fix a bug with the Chrome legacy window at times becoming a top level window
with a non functional button in the taskbar.

This bug typically occurs if the legacy window stays around after it is
removed from the original root window.

It looks like a recent change (https://codereview.chromium.org/1996163002)
which ensures that the legacy window is always created exacerbates this
problem by creating the legacy windows early and some of them stay around
after a tab switch. Typical cases include opening a pdf file in chrome
which causes at least two RWVHA instances to be active at any given point
and the legacy window which belongs to the original instance becomes a
button on the taskbar when the tab is switched.

Fix is to never reparent to the desktop window and instead always reparent
to the hidden window.

BUG=616410
==========

[ncarter (slow), 2016-06-03 19:37:59]

nick@chromium.org changed reviewers:
+ nick@chromium.org
- ncarter@chromium.org

[ananta, 2016-06-03 19:41:53]

+nick for real this time

[ncarter (slow), 2016-06-03 20:13:23]

lgtm

[ananta, 2016-06-03 20:15:25]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2016-06-03 20:15:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031213002/1

[commit-bot: I haz the power, 2016-06-03 20:20:34]

Description was changed from

==========
Fix a bug with the Chrome legacy window at times becoming a top level window
with a non functional button in the taskbar.

This bug typically occurs if the legacy window stays around after it is
removed from the original root window.

It looks like a recent change (https://codereview.chromium.org/1996163002)
which ensures that the legacy window is always created exacerbates this
problem by creating the legacy windows early and some of them stay around
after a tab switch. Typical cases include opening a pdf file in chrome
which causes at least two RWVHA instances to be active at any given point
and the legacy window which belongs to the original instance becomes a
button on the taskbar when the tab is switched.

Fix is to never reparent to the desktop window and instead always reparent
to the hidden window.

BUG=616410
==========

to

==========
Fix a bug with the Chrome legacy window at times becoming a top level window
with a non functional button in the taskbar.

This bug typically occurs if the legacy window stays around after it is
removed from the original root window.

It looks like a recent change (https://codereview.chromium.org/1996163002)
which ensures that the legacy window is always created exacerbates this
problem by creating the legacy windows early and some of them stay around
after a tab switch. Typical cases include opening a pdf file in chrome
which causes at least two RWVHA instances to be active at any given point
and the legacy window which belongs to the original instance becomes a
button on the taskbar when the tab is switched.

Fix is to never reparent to the desktop window and instead always reparent
to the hidden window.

BUG=616410
==========

[commit-bot: I haz the power, 2016-06-03 20:20:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-03 20:22:57]

Description was changed from

==========
Fix a bug with the Chrome legacy window at times becoming a top level window
with a non functional button in the taskbar.

This bug typically occurs if the legacy window stays around after it is
removed from the original root window.

It looks like a recent change (https://codereview.chromium.org/1996163002)
which ensures that the legacy window is always created exacerbates this
problem by creating the legacy windows early and some of them stay around
after a tab switch. Typical cases include opening a pdf file in chrome
which causes at least two RWVHA instances to be active at any given point
and the legacy window which belongs to the original instance becomes a
button on the taskbar when the tab is switched.

Fix is to never reparent to the desktop window and instead always reparent
to the hidden window.

BUG=616410
==========

to

==========
Fix a bug with the Chrome legacy window at times becoming a top level window
with a non functional button in the taskbar.

This bug typically occurs if the legacy window stays around after it is
removed from the original root window.

It looks like a recent change (https://codereview.chromium.org/1996163002)
which ensures that the legacy window is always created exacerbates this
problem by creating the legacy windows early and some of them stay around
after a tab switch. Typical cases include opening a pdf file in chrome
which causes at least two RWVHA instances to be active at any given point
and the legacy window which belongs to the original instance becomes a
button on the taskbar when the tab is switched.

Fix is to never reparent to the desktop window and instead always reparent
to the hidden window.

BUG=616410

Committed: https://crrev.com/b35c046639c244df4a954a791e24cfe7d5270daa
Cr-Commit-Position: refs/heads/master@{#397790}
==========

[commit-bot: I haz the power, 2016-06-03 20:22:59]

Patchset 1 (id:??) landed as
https://crrev.com/b35c046639c244df4a954a791e24cfe7d5270daa
Cr-Commit-Position: refs/heads/master@{#397790}