[Courgette] Refactor BSDiff namespaces and bsdiff::search() interface.

[Courgette] Refactor BSDiff namespaces and bsdiff::search() interface.

Details:
- Move BSDiff (but not PagedArray) from namespace courgette to bsdiff.
- Change namespace courgette::qsuf to qsuf.
- Change bsdiff:search() to return struct {pos, size} so we don't need
  awkward pointer passing; update callers.
- Updated BSDiff callers. Also fix weird hybrid usage by setup_util.cc,
  which calls Courgette's BSDiff, but using OK from BSPatch.

BUG=608885
Committed: https://crrev.com/7054b5a2e3b2ce7f5b2e868e91d54b5ec0773089
Cr-Commit-Position: refs/heads/master@{#407924}

[huangs, 2016-06-03 02:00:50]

The CQ bit was checked by huangs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 02:02:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031193002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031193002/1

[commit-bot: I haz the power, 2016-06-03 02:14:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 02:14:57]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[huangs, 2016-06-03 04:31:03]

Description was changed from

==========
[Courgette] Refactor BSDiff namespaces; extract BSDiff search() to new file.

Details:
- Move BSDiff (but not PagedArray) from namespace courgette to bsdiff.
- Change namespace courgette::qsuf to qsuf.
- Move BSDiff's search() and matchlen() to a separate file, and from
  namespace qsuf to bsdiff, since we'll replace QSufSort with divsufsort
  but still use these.
- Updated callers.

BUG=608885
==========

to

==========
[Courgette] Refactor BSDiff namespaces; extract BSDiff search() to new file.

Details:
- Move BSDiff (but not PagedArray) from namespace courgette to bsdiff.
- Change namespace courgette::qsuf to qsuf.
- Move BSDiff's search() and matchlen() to a separate file, and from
  namespace qsuf to bsdiff, since we'll replace QSufSort with divsufsort
  but still use these.
- Updated callers. Also fix weird hybrid usage by setup_util.cc, which
  calls Courgette's BSDiff, but using OK from BSPatch.

BUG=608885
==========

[huangs, 2016-06-03 05:06:36]

The CQ bit was checked by huangs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 05:06:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031193002/40001

[huangs, 2016-06-03 05:12:04]

huangs@chromium.org changed reviewers:
+ chrisha@chromium.org, grt@chromium.org

[huangs, 2016-06-03 05:12:05]

chrisha@: Decided to do some refactoring before I replace QSufSort with
divsufsort. PTAL the Courgette side.

grt@: PTAL installer side.  There's some oddity on Installer using 2 versions of
BSDiff.

Thanks!

https://chromiumcodereview.appspot.com/2031193002/diff/40001/chrome/installer...
File chrome/installer/setup/setup_util.cc (right):

https://chromiumcodereview.appspot.com/2031193002/diff/40001/chrome/installer...
chrome/installer/setup/setup_util.cc:90: const int exit_code = patch_status !=
bsdiff::OK ?
This was Frankenstein before: Using BSDiff from Courgette, but OK from BSPatch.
Having the bsdiff namespace is nice.

However, chrome/installer/setup/archive_patch_helper.cc still uses MBSPatch.  I
left it alone, but it's odd that Installer is using both Courgette and BSPatch
versions?

[commit-bot: I haz the power, 2016-06-03 06:49:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 06:49:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[huangs, 2016-06-03 15:46:05]

Updated licenses, want to see if this makes trybot happy.

I'll extract the license change to a separate CL, and merge it in after.

[grt (UTC plus 2), 2016-06-03 15:58:36]

+mmoss to comment on below.

https://codereview.chromium.org/2031193002/diff/40001/chrome/installer/setup/...
File chrome/installer/setup/setup_util.cc (right):

https://codereview.chromium.org/2031193002/diff/40001/chrome/installer/setup/...
chrome/installer/setup/setup_util.cc:90: const int exit_code = patch_status !=
bsdiff::OK ?
On 2016/06/03 05:12:05, huangs wrote:
> This was Frankenstein before: Using BSDiff from Courgette, but OK from
BSPatch.
> Having the bsdiff namespace is nice.
> 
> However, chrome/installer/setup/archive_patch_helper.cc still uses MBSPatch. 
I
> left it alone, but it's odd that Installer is using both Courgette and BSPatch
> versions?

Maybe we can get rid of the use of mbspatch in archive_patch_helper now. mmoss:
is my understanding correct that we now only build what was once called the
"3-stage" diff updater? Is there any reason not to ditch the code in Chrome that
handles the non-3-stage variant?

[Michael Moss, 2016-06-03 16:40:19]

mmoss@chromium.org changed reviewers:
+ mmoss@chromium.org

[Michael Moss, 2016-06-03 16:40:20]

https://codereview.chromium.org/2031193002/diff/40001/chrome/installer/setup/...
File chrome/installer/setup/setup_util.cc (right):

https://codereview.chromium.org/2031193002/diff/40001/chrome/installer/setup/...
chrome/installer/setup/setup_util.cc:90: const int exit_code = patch_status !=
bsdiff::OK ?
> is my understanding correct that we now only build what was once called the
> "3-stage" diff updater? Is there any reason not to ditch the code in Chrome
that
> handles the non-3-stage variant?

Correct, we've only had 3-stage for many months now. There is still code to
generate the others, but it's disabled by default, and I'd be more than happy to
remove it entirely.

[huangs, 2016-06-06 04:53:35]

https://chromiumcodereview.appspot.com/2031193002/diff/60001/courgette/third_...
File courgette/third_party/bsdiff/bsdiff_search.h (right):

https://chromiumcodereview.appspot.com/2031193002/diff/60001/courgette/third_...
courgette/third_party/bsdiff/bsdiff_search.h:53: // We use binary search here,
but the desired position is not the usual
In retrospect this is ridiculously verbose.  Will shorten.

[huangs, 2016-06-20 18:03:19]

Update: Moving BSDiff search() extraction to separate file to this CL:
http://crrev.com/2078743002

Will merge later.

[huangs, 2016-06-29 15:56:48]

Description was changed from

==========
[Courgette] Refactor BSDiff namespaces; extract BSDiff search() to new file.

Details:
- Move BSDiff (but not PagedArray) from namespace courgette to bsdiff.
- Change namespace courgette::qsuf to qsuf.
- Move BSDiff's search() and matchlen() to a separate file, and from
  namespace qsuf to bsdiff, since we'll replace QSufSort with divsufsort
  but still use these.
- Updated callers. Also fix weird hybrid usage by setup_util.cc, which
  calls Courgette's BSDiff, but using OK from BSPatch.

BUG=608885
==========

to

==========
[Courgette] Refactor BSDiff namespaces and bsdiff::search() interface.

Details:
- Move BSDiff (but not PagedArray) from namespace courgette to bsdiff.
- Change namespace courgette::qsuf to qsuf.
- Change bsdiff:search() to return struct {pos, size} so we don't need
  awkward pointer passing; update callers.
- Updated BSDiff callers. Also fix weird hybrid usage by setup_util.cc,
  which calls Courgette's BSDiff, but using OK from BSPatch.

BUG=608885
==========

[huangs, 2016-06-29 15:56:48]

huangs@chromium.org changed reviewers:
- grt@chromium.org, mmoss@chromium.org

[huangs, 2016-06-29 15:59:14]

PTAL chrisha@ for general review (before bugging OWNERs for various call sites
outside Courgette).

After this there will be 2 more CLs:
- (Small refactor) Move PagedArray from \courgette\third_party\bsdiff to
\courgette.
- Main libdivsufsort CL (experimental: http://crrev.com/1948843002).

[chrisha, 2016-07-08 14:46:32]

lgtm!

[huangs, 2016-07-11 15:49:52]

huangs@chromium.org changed reviewers:
+ jochen@chromium.org

[huangs, 2016-07-11 15:49:53]

Thanks.  +jochen@ for OWNER review for:

  chrome\installer\setup\setup_util.cc
  chrome\utility\chrome_content_utility_client.cc
  components\update_client\component_patcher_operation.cc

PTAL. Thanks!

[jochen (gone - plz use gerrit), 2016-07-12 15:09:44]

lgtm

[huangs, 2016-07-12 15:10:51]

Thanks! Committing.

[huangs, 2016-07-12 15:10:59]

The CQ bit was checked by huangs@chromium.org

[huangs, 2016-07-12 15:11:00]

The patchset sent to the CQ was uploaded after l-g-t-m from chrisha@chromium.org
Link to the patchset: https://codereview.chromium.org/2031193002/#ps160001
(title: "Sync and merge.")

[commit-bot: I haz the power, 2016-07-12 15:12:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 16:49:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 16:49:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[huangs, 2016-07-12 17:00:41]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2016-07-12 17:01:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:34:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:34:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[huangs, 2016-07-26 18:10:24]

Oops didn't see that this didn't commit.  Will retry after sync!

[huangs, 2016-07-26 20:49:12]

The CQ bit was checked by huangs@chromium.org

[huangs, 2016-07-26 20:49:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
chrisha@chromium.org
Link to the patchset: https://codereview.chromium.org/2031193002/#ps180001
(title: "Sync.")

[commit-bot: I haz the power, 2016-07-26 20:49:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 21:46:34]

Description was changed from

==========
[Courgette] Refactor BSDiff namespaces and bsdiff::search() interface.

Details:
- Move BSDiff (but not PagedArray) from namespace courgette to bsdiff.
- Change namespace courgette::qsuf to qsuf.
- Change bsdiff:search() to return struct {pos, size} so we don't need
  awkward pointer passing; update callers.
- Updated BSDiff callers. Also fix weird hybrid usage by setup_util.cc,
  which calls Courgette's BSDiff, but using OK from BSPatch.

BUG=608885
==========

to

==========
[Courgette] Refactor BSDiff namespaces and bsdiff::search() interface.

Details:
- Move BSDiff (but not PagedArray) from namespace courgette to bsdiff.
- Change namespace courgette::qsuf to qsuf.
- Change bsdiff:search() to return struct {pos, size} so we don't need
  awkward pointer passing; update callers.
- Updated BSDiff callers. Also fix weird hybrid usage by setup_util.cc,
  which calls Courgette's BSDiff, but using OK from BSPatch.

BUG=608885
==========

[commit-bot: I haz the power, 2016-07-26 21:46:35]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-07-26 21:49:02]

Description was changed from

==========
[Courgette] Refactor BSDiff namespaces and bsdiff::search() interface.

Details:
- Move BSDiff (but not PagedArray) from namespace courgette to bsdiff.
- Change namespace courgette::qsuf to qsuf.
- Change bsdiff:search() to return struct {pos, size} so we don't need
  awkward pointer passing; update callers.
- Updated BSDiff callers. Also fix weird hybrid usage by setup_util.cc,
  which calls Courgette's BSDiff, but using OK from BSPatch.

BUG=608885
==========

to

==========
[Courgette] Refactor BSDiff namespaces and bsdiff::search() interface.

Details:
- Move BSDiff (but not PagedArray) from namespace courgette to bsdiff.
- Change namespace courgette::qsuf to qsuf.
- Change bsdiff:search() to return struct {pos, size} so we don't need
  awkward pointer passing; update callers.
- Updated BSDiff callers. Also fix weird hybrid usage by setup_util.cc,
  which calls Courgette's BSDiff, but using OK from BSPatch.

BUG=608885

Committed: https://crrev.com/7054b5a2e3b2ce7f5b2e868e91d54b5ec0773089
Cr-Commit-Position: refs/heads/master@{#407924}
==========

[commit-bot: I haz the power, 2016-07-26 21:49:03]

Patchset 10 (id:??) landed as
https://crrev.com/7054b5a2e3b2ce7f5b2e868e91d54b5ec0773089
Cr-Commit-Position: refs/heads/master@{#407924}