Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 2031143002: Add unit tests for ArcBridgeService::RemoveObserver() (Closed)

Created:
4 years, 6 months ago by Yusuke Sato
Modified:
4 years, 6 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unit tests for ArcBridgeService::RemoveObserver() to make sure that passing unknown pointers to the function is harmless. https://codereview.chromium.org/2034543003/ for example relies on the behavior. BUG=None TEST=try Committed: https://crrev.com/167ddcdf336e15ce90ede703adac78d70cf3c150 Cr-Commit-Position: refs/heads/master@{#397565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M components/arc/arc_bridge_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/arc/arc_bridge_service_unittest.cc View 4 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Yusuke Sato
PTAL
4 years, 6 months ago (2016-06-02 22:54:59 UTC) #2
Luis Héctor Chávez
lgtm thanks for doing this!
4 years, 6 months ago (2016-06-02 22:56:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031143002/1
4 years, 6 months ago (2016-06-02 22:58:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 00:42:03 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 00:44:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/167ddcdf336e15ce90ede703adac78d70cf3c150
Cr-Commit-Position: refs/heads/master@{#397565}

Powered by Google App Engine
This is Rietveld 408576698