Issue 203113002: Revert of Reapply 169354 "DevTools: track stylesheets by document, not local frame"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203113002: Revert of Reapply 169354 "DevTools: track stylesheets by document, not local frame" (Closed)

Created:
6 years, 9 months ago by pfeldman

Modified:
6 years, 9 months ago

Reviewers:
vsevik

CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, alph+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, Inactive, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of Reapply 169354 "DevTools: track stylesheets by document, not local frame" (https://codereview.chromium.org/202623003/) Reason for revert: Seems like there are more failures. Original issue's description: > Reapply 169354 "DevTools: track stylesheets by document, not local frame" > > BUG=353257 > TBR=vsevik > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169413 TBR=vsevik@chromium.org NOTREECHECKS=true NOTRY=true BUG=353257 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169420

Patch Set 1 #

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -50 lines)			Patch
M	Source/core/dom/Document.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.h	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View	6 chunks	+33 lines, -38 lines	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.idl	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/StylesSidebarPane.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

Created Revert of Reapply 169354 "DevTools: track stylesheets by document, not local frame"

6 years, 9 months ago (2014-03-18 06:16:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/203113002/1

6 years, 9 months ago (2014-03-18 06:16:21 UTC) #2

Message was sent while issue was closed.

Change committed as 169420

Expand Messages | Collapse Messages