Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2031113003: Don't use complex blend mode for shapes gm (Closed)

Created:
4 years, 6 months ago by csmartdalton
Modified:
4 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't use complex blend mode for shapes gm The darken blend mode introduced barriers on most platforms, which interfered with batching. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2031113003 Committed: https://skia.googlesource.com/skia/+/87fee2380cba0ca13b8b2892ac2232fb8e04b6ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gm/shapes.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
csmartdalton
4 years, 6 months ago (2016-06-03 17:21:43 UTC) #3
bsalomon
lgtm
4 years, 6 months ago (2016-06-03 17:28:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031113003/1
4 years, 6 months ago (2016-06-03 17:37:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/8949)
4 years, 6 months ago (2016-06-03 17:45:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031113003/1
4 years, 6 months ago (2016-06-03 18:40:36 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 18:56:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/87fee2380cba0ca13b8b2892ac2232fb8e04b6ab

Powered by Google App Engine
This is Rietveld 408576698