IndexedDB Observers

third_party/WebKit/Source/modules/indexeddb/IDBObserverCallback.h

Index: third_party/WebKit/Source/modules/indexeddb/IDBObserverCallback.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserverCallback.h b/third_party/WebKit/Source/modules/indexeddb/IDBObserverCallback.h
new file mode 100644
index 0000000000000000000000000000000000000000..533ba2cec63ae8a7168167ae95200f05b0de5f7d
--- /dev/null
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserverCallback.h
@@ -0,0 +1,24 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IDBObserverCallback_h
+#define IDBObserverCallback_h
+
+#include "platform/heap/Handle.h"

[dmurph, 2016/06/15 19:35:15]

I guess Oilpan uses this to include everything? Seems weird, but I see it
everywhere.

[palakj1, 2016/06/15 21:24:49]

I can remove this header from this and all other files. Since, it's anyway
included through IDBDatabase (transitive dependecies). 
Would you like that better? Or should I still include particular headers used
for tracing instead of Handle.h?

[dmurph, 2016/06/15 21:28:35]

No, it looks like other users of Oilpan (who use GarbageCollectedFinalized, etc)
in modules also have this 'batch' include to include the oilpan macros & basic
stuff. This is fine.

Please don't rely on transitive dependencies, unless they come from the header
file for your class :)

[haraken, 2016/06/16 00:22:29]

We normally just include Handle.h to use Oilpan stuff, just like we normally
include v8.h to use V8 stuff. This is not recommended but is a commonly used
pattern.

+
+namespace blink {
+
+class ExecutionContext;
+class IDBObserver;
+
+class IDBObserverCallback : public GarbageCollectedFinalized<IDBObserverCallback> {
+public:
+    virtual ~IDBObserverCallback() {}
+    virtual ExecutionContext* getExecutionContext() const = 0;
+    DEFINE_INLINE_VIRTUAL_TRACE() {}
+};
+
+} // namespace blink
+
+#endif // IDBObserverCallback_h