IndexedDB Observers

third_party/WebKit/Source/modules/indexeddb/IDBObserverChangesRecord.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.+
+
+#ifndef IDBObserverChangesRecord_h
+#define IDBObserverChangesRecord_h
+
+#include "bindings/core/v8/ScriptValue.h"
+#include "bindings/core/v8/ScriptWrappable.h"
+#include "platform/heap/Handle.h"
+#include "public/platform/modules/indexeddb/WebIDBTypes.h"
+#include "wtf/PassRefPtr.h"
+
+namespace blink {
+
+class ScriptState;
+class IDBKey;
+class IDBValue;
+
+class IDBObserverChangesRecord final : public GarbageCollectedFinalized<IDBObserverChangesRecord>, public ScriptWrappable {
+    DEFINE_WRAPPERTYPEINFO();
+
+public:
+    static WebIDBOperationType stringToOperationType(const String&);
+    static IDBObserverChangesRecord* create(IDBKey*, IDBValue*, WebIDBOperationType);
+    virtual ~IDBObserverChangesRecord();
+
+    DECLARE_TRACE();
+
+    // Implement the IDL
+    ScriptValue key(ScriptState*);
+    ScriptValue value(ScriptState*);
+    const String& type() const;
+
+private:
+    IDBObserverChangesRecord(IDBKey*, IDBValue*, WebIDBOperationType);
+    Member<IDBKey> m_key;
+    PassRefPtr<IDBValue> m_value;

[Marijn Kruisselbrink, 2016/06/16 07:09:30]

No, this isn't what I mean. You should of course store m_value as a RefPtr. It's
the raw IDBValue* pointers in the constructor and create method that should be
PassRefPtr<IDBValue> instead.

[palakj1, 2016/06/16 17:05:24]

Oh okay. Changed

+    const WebIDBOperationType m_operationType;
+};
+
+} // namespace blink
+
+#endif // IDBObserverChangesRecord_h