third_party/WebKit/LayoutTests/http/tests/fetch/workers/observer.html - Issue 2031113002: IndexedDB Observers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/fetch/workers/observer.html

Issue 2031113002: IndexedDB Observers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Observer idl with worker tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/observer.js ('K') | « third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/observer.js ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt » ('j') | third_party/WebKit/LayoutTests/storage/indexeddb/observer.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>
	Marijn Kruisselbrink 2016/06/08 20:44:41 Here too move this file to something like LayoutTe Here too move this file to something like LayoutTests/storage/indexeddb/observer-worker.html
	2 <head>
	Marijn Kruisselbrink 2016/06/08 20:44:41 nit: You don't really need the head (or the body), nit: You don't really need the head (or the body), just like the other observer.html this entire file can be pretty much just: <!DOCTYPE html> <title>IndexedDB: Observer Tests in Workers</title> <script src="../../resources/testharness.js"></script> <script src="../../resources/testharnessreport.js"></script> <script> fetch_tests_from_worker( new Worker('resources/observer-tests.js')); </script> palakj1 2016/06/09 18:13:38 Done Show quoted text On 2016/06/08 at 20:44:41, Marijn Kruisselbrink wrote: > nit: You don't really need the head (or the body), just like the other observer.html this entire file can be pretty much just: > > <!DOCTYPE html> > <title>IndexedDB: Observer Tests in Workers</title> > <script src="../../resources/testharness.js"></script> > <script src="../../resources/testharnessreport.js"></script> > <script> > fetch_tests_from_worker( > new Worker('resources/observer-tests.js')); > </script> Done
	3 <script src = "/resources/testharness.js"></script>

	4 <script src = "/resources/testharnessreport.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 fetch_tests_from_worker(

	9 new Worker('../script-tests/observer.js?'));

	10 </script>

	11 </body>

	12

OLD	NEW