third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/observer.js - Issue 2031113002: IndexedDB Observers - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(164)

My Issues | Starred Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/observer.js

Issue 2031113002: IndexedDB Observers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Observer idl with worker tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/fetch/workers/observer.html » ('j') | third_party/WebKit/LayoutTests/http/tests/fetch/workers/observer.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 if (self.importScripts) {
	Marijn Kruisselbrink 2016/06/08 20:44:40 It doesn't really make sense to have this file in It doesn't really make sense to have this file in the fetch tests directory. You should just keep everything together in LayoutTests/storage/indexeddb. Probably something like LayoutTests/storage/indexeddb/resources/observer-tests.js
	2 importScripts('../resources/fetch-test-helpers.js');
	Marijn Kruisselbrink 2016/06/08 20:44:40 After moving the file you'll have to change this t After moving the file you'll have to change this to be the correct path to testharness.js rather than fetch-test-helpers.js palakj1 2016/06/09 18:13:38 Done Show quoted text On 2016/06/08 at 20:44:40, Marijn Kruisselbrink wrote: > After moving the file you'll have to change this to be the correct path to testharness.js rather than fetch-test-helpers.js Done
	3 }

	4

	5 function callback(){};

	6

	7 test(function(t) {
	Marijn Kruisselbrink 2016/06/08 20:44:40 This should still be an async_test, like the one y This should still be an async_test, like the one you have in observer.html palakj1 2016/06/09 18:13:38 done Show quoted text On 2016/06/08 at 20:44:40, Marijn Kruisselbrink wrote: > This should still be an async_test, like the one you have in observer.html done
	8 var description = 'observers constructor test';

	9 var dbname = location.pathname + ' - ' + description;

	10 var openRequest = indexedDB.open(dbname);

	11 var obs1 = new IDBObserver(callback, {transaction: true, values: true});

	12 openRequest.onupgradeneeded= function() {
	Marijn Kruisselbrink 2016/06/08 20:44:41 nit: space before = nit: space before = palakj1 2016/06/09 18:13:38 Done Show quoted text On 2016/06/08 at 20:44:41, Marijn Kruisselbrink wrote: > nit: space before = Done
	13 var db = openRequest.result;

	14 db.createObjectStore('store');

	15 };

	16 openRequest.onsuccess = function() {

	17 var db = openRequest.result;

	18 var tx = db.transaction('store', 'readwrite');

	19 obs1.observe(db,tx);
	Marijn Kruisselbrink 2016/06/08 20:44:40 nit: space after , nit: space after , palakj1 2016/06/09 18:13:38 Done Show quoted text On 2016/06/08 at 20:44:40, Marijn Kruisselbrink wrote: > nit: space after , Done
	20 done();
	Marijn Kruisselbrink 2016/06/08 20:44:40 this should be t.done() this should be t.done() palakj1 2016/06/09 18:13:38 Done Show quoted text On 2016/06/08 at 20:44:40, Marijn Kruisselbrink wrote: > this should be t.done() Done
	21 };

	22

	23 }, 'observers constructor test');

	24

	25 // done();
	Marijn Kruisselbrink 2016/06/08 20:44:40 And you'll need to uncomment this (to signal "all And you'll need to uncomment this (to signal "all the tests have been added to the test framework") palakj1 2016/06/09 18:13:38 Done Show quoted text On 2016/06/08 at 20:44:40, Marijn Kruisselbrink wrote: > And you'll need to uncomment this (to signal "all the tests have been added to the test framework") Done
OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/fetch/workers/observer.html » ('j') | third_party/WebKit/LayoutTests/http/tests/fetch/workers/observer.html » ('J')

Powered by Google App Engine

This is Rietveld 408576698