third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl - Issue 2031113002: IndexedDB Observers

Side by Side Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl

Issue 2031113002: IndexedDB Observers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Expected files Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/Source/modules/indexeddb/IDBObserver.idl ('K') | « third_party/WebKit/Source/modules/indexeddb/IDBObserverCallback.h ('k') | third_party/WebKit/Source/modules/indexeddb/IDBObserverChangesRecord.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 RuntimeEnabled=IDBObserver

	7 ] dictionary IDBObserverChanges {
	Marijn Kruisselbrink 2016/06/06 23:09:10 I wonder if this (and IDBOvserverChangesRecord) sh I wonder if this (and IDBOvserverChangesRecord) shouldn't be an interface rather than a dictionary? But that's probably more a spec question, so feel free to ignore for now. Generally dictionaries are used to pass things from javascript to APIs, while interfaces are used to pass data from the platform back to javascript. palakj1 2016/06/07 00:11:16 Thanks for this. Didn't know about it. I'll make t Show quoted text On 2016/06/06 at 23:09:10, Marijn Kruisselbrink wrote: > I wonder if this (and IDBOvserverChangesRecord) shouldn't be an interface rather than a dictionary? But that's probably more a spec question, so feel free to ignore for now. Generally dictionaries are used to pass things from javascript to APIs, while interfaces are used to pass data from the platform back to javascript. Thanks for this. Didn't know about it. I'll make the changes after discussion with @dmuprh. dmurph 2016/06/07 00:19:20 Ah, does it make a big difference? We just want si Show quoted text On 2016/06/06 at 23:09:10, Marijn Kruisselbrink wrote: > I wonder if this (and IDBOvserverChangesRecord) shouldn't be an interface rather than a dictionary? But that's probably more a spec question, so feel free to ignore for now. Generally dictionaries are used to pass things from javascript to APIs, while interfaces are used to pass data from the platform back to javascript. Ah, does it make a big difference? We just want simple a data storage "pojo". It looks like the intersection observer uses interface and not dictionary (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/Inter...), so maybe that's better?
	8 IDBDatabase db;

	9 // Transaction contains the same object stores as the transaction on which I DBTransaction.observe was called.

	10 IDBTransaction transaction;

	11 // This is the javascript Map<String, sequence<IDBObserverChangesRecord>>,

	12 // where the key is the object store name.

	13 any records;
	Marijn Kruisselbrink 2016/06/06 23:09:10 And this is really getting into more questioning t And this is really getting into more questioning the spec rather than this implementation of it; but would it make sense to have IDBObserverChanges be a "maplike<DOMString, FrozenArray<IDBObserverChangesRecord>> (thereby behaving like an ecmascript Map itself) rather than just containing a map? palakj1 2016/06/07 00:11:16 I don't have enough knowledge about it. It would b Show quoted text On 2016/06/06 at 23:09:10, Marijn Kruisselbrink wrote: > And this is really getting into more questioning the spec rather than this implementation of it; but would it make sense to have IDBObserverChanges be a "maplike<DOMString, FrozenArray<IDBObserverChangesRecord>> (thereby behaving like an ecmascript Map itself) rather than just containing a map? I don't have enough knowledge about it. It would be great if we could discuss about this. dmurph 2016/06/07 00:19:20 That's really cool, I didn't know we had those key Show quoted text On 2016/06/06 at 23:09:10, Marijn Kruisselbrink wrote: > And this is really getting into more questioning the spec rather than this implementation of it; but would it make sense to have IDBObserverChanges be a "maplike<DOMString, FrozenArray<IDBObserverChangesRecord>> (thereby behaving like an ecmascript Map itself) rather than just containing a map? That's really cool, I didn't know we had those keywords available.
	14 };

	15

OLD	NEW