third_party/WebKit/Source/modules/indexeddb/IDBObserver.idl - Issue 2031113002: IndexedDB Observers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserver.idl

Issue 2031113002: IndexedDB Observers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Expected files Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp ('K') | « third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBObserverCallback.h » ('j') | third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 callback IDBObserverCallback = void (IDBObserverChanges changes);
	Marijn Kruisselbrink 2016/06/06 23:09:10 Can you add a comment to every type you define in Can you add a comment to every type you define in all these IDL files with a link to the (section of) the spec that defines that type? See all the other IDL files here and in other parts of blink. In particular there seem to be a number of discrepancies between these idl definitions and the closest thing to a spec I could find (https://github.com/WICG/indexed-db-observers/blob/gh-pages/IDBObservers.webidl), so I wonder if I'm looking at the wrong thing. palakj1 2016/06/07 00:11:16 The specs have been changed a bit. I've added the Show quoted text On 2016/06/06 at 23:09:10, Marijn Kruisselbrink wrote: > Can you add a comment to every type you define in all these IDL files with a link to the (section of) the spec that defines that type? See all the other IDL files here and in other parts of blink. > > In particular there seem to be a number of discrepancies between these idl definitions and the closest thing to a spec I could find (https://github.com/WICG/indexed-db-observers/blob/gh-pages/IDBObservers.webidl), so I wonder if I'm looking at the wrong thing. The specs have been changed a bit. I've added the references. Will keep this in mind for future work. dmurph 2016/06/07 00:19:20 regarding the spec you found, see this issue for o Show quoted text On 2016/06/07 at 00:11:16, palakj1 wrote: > On 2016/06/06 at 23:09:10, Marijn Kruisselbrink wrote: > > Can you add a comment to every type you define in all these IDL files with a link to the (section of) the spec that defines that type? See all the other IDL files here and in other parts of blink. > > > > In particular there seem to be a number of discrepancies between these idl definitions and the closest thing to a spec I could find (https://github.com/WICG/indexed-db-observers/blob/gh-pages/IDBObservers.webidl), so I wonder if I'm looking at the wrong thing. > > The specs have been changed a bit. I've added the references. Will keep this in mind for future work. regarding the spec you found, see this issue for our idl structure: https://github.com/WICG/indexed-db-observers/issues/24 I'm going to be changing the IDL on GitHub soon.
	6 [

	7 Exposed=(Window,Worker),

	8 CustomConstructor(IDBObserverCallback callback, IDBObserverInit options),

	9 RuntimeEnabled=IDBObserver,

	10 ] interface IDBObserver {

	11 [RaisesException] void observe(IDBDatabase db, IDBTransaction tx);

	12 };

OLD	NEW