third_party/WebKit/LayoutTests/storage/indexeddb/observer.html - Issue 2031113002: IndexedDB Observers

Side by Side Diff: third_party/WebKit/LayoutTests/storage/indexeddb/observer.html

Issue 2031113002: IndexedDB Observers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Expected files Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt ('k') | third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt » ('j') | third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>IndexedDB: UpgradeNeeded Tests</title>
	Marijn Kruisselbrink 2016/06/06 23:09:10 This seems wrong? This seems wrong? palakj1 2016/06/07 00:11:16 Sorry. updated. Show quoted text On 2016/06/06 at 23:09:10, Marijn Kruisselbrink wrote: > This seems wrong? Sorry. updated.
	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6

	7

	8 function callback(){

	9 console.log('callit');
	Marijn Kruisselbrink 2016/06/06 23:09:10 Logging to the console almost never seems like the Logging to the console almost never seems like the right thing to do in a test. Probably you just want to pass an empty callback to the IDBObserver constructor? palakj1 2016/06/07 00:11:16 Done Show quoted text On 2016/06/06 at 23:09:10, Marijn Kruisselbrink wrote: > Logging to the console almost never seems like the right thing to do in a test. Probably you just want to pass an empty callback to the IDBObserver constructor? Done
	10 }

	11

	12 (function () {
	Marijn Kruisselbrink 2016/06/06 23:09:10 Wrapping the async_test inside a (function() { ... Wrapping the async_test inside a (function() { ... }()); doesn't really gain you anything. The entire test is contained within the function passed to async_test anyway. palakj1 2016/06/07 00:11:16 Got your point. Done. Show quoted text On 2016/06/06 at 23:09:10, Marijn Kruisselbrink wrote: > Wrapping the async_test inside a (function() { ... }()); doesn't really gain you anything. The entire test is contained within the function passed to async_test anyway. Got your point. Done.
	13 async_test(function(t) {

	14 var description = 'observers constructor test';

	15 var dbname = location.pathname + ' - ' + description;

	16 var openRequest = indexedDB.open(dbname);

	17 var obs1 = new IDBObserver(callback, {transaction: true, values: true});

	18 openRequest.onupgradeneeded= t.step_func(function() {

	19 var db = openRequest.result;

	20 db.createObjectStore('store');

	21 });

	22 openRequest.onsuccess = t.step_func(function() {

	23 var db = openRequest.result;

	24 var tx = db.transaction('store', 'readwrite');

	25 obs1.observe(db,tx);

	26 t.done();

	27 });

	28

	29 }, 'observers constructor test');

	30 }());

	31

	32
	Marijn Kruisselbrink 2016/06/06 23:09:10 Maybe also run the same tests from a worker contex Maybe also run the same tests from a worker context? Could be as simple as moving the actual tests to a resources/observer-tests.js file and having one html file include that js script directly, and another html file calling fetch_tests_from_worker(new Worker('resources/observer-tests.js')); palakj1 2016/06/07 00:11:16 I'll work on this. Show quoted text On 2016/06/06 at 23:09:10, Marijn Kruisselbrink wrote: > Maybe also run the same tests from a worker context? Could be as simple as moving the actual tests to a resources/observer-tests.js file and having one html file include that js script directly, and another html file calling fetch_tests_from_worker(new Worker('resources/observer-tests.js')); I'll work on this.
	33 </script>

OLD	NEW