Fix canonicalization of --url_mapping URIs in gen_snapshot

Fix canonicalization of --url_mapping URIs in gen_snapshot

When gen_snapshot encounters a url that has been remapped with the --url_mapping command line argument it rewrites the library's url to be the mapped url before canonicalization. The new C++ API only does canonicalization with respect to the library's url (as returned by Dart_LibraryUrl) which is insufficient for gen_snapshot. The correct long-term fix is to alter the new C++ API to allow for the base url to be passed in directly rather than indirectly via Dart_LibraryUrl.

This CL just restores some deleted code and has gen_snapshot work like it did before. The standalone embedder still uses the C++ API during loading.

Dartium build failures: https://build.chromium.org/p/client.dart/builders/dartium-mac-inc-be/builds/12488/steps/compile/logs/stdio

Committed: https://github.com/dart-lang/sdk/commit/d47866964cc6e3a6c00f50ab539f383408c78bf2

[Cutch, 2016-06-02 21:49:16]

Description was changed from

==========
Fix canonicalization of --url_mapping URIs in gen_snapshot

BUG=
==========

to

==========
Fix canonicalization of --url_mapping URIs in gen_snapshot


When gen_snapshot encounters a url that has been remapped with the --url_mapping
command line argument it rewrites the library's url to be the mapped url before
canonicalization. The new C++ API only does canonicalization with respect to the
library's url (as returned by Dart_LibraryUrl) which is insufficient for
gen_snapshot.

The correct long-term fix is to alter the new C++ API to allow for the base url
to be passed in directly rather than indirectly via Dart_LibraryUrl.
==========

[Cutch, 2016-06-02 21:49:16]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[Cutch, 2016-06-02 21:50:44]

Description was changed from

==========
Fix canonicalization of --url_mapping URIs in gen_snapshot


When gen_snapshot encounters a url that has been remapped with the --url_mapping
command line argument it rewrites the library's url to be the mapped url before
canonicalization. The new C++ API only does canonicalization with respect to the
library's url (as returned by Dart_LibraryUrl) which is insufficient for
gen_snapshot.

The correct long-term fix is to alter the new C++ API to allow for the base url
to be passed in directly rather than indirectly via Dart_LibraryUrl.
==========

to

==========
Fix canonicalization of --url_mapping URIs in gen_snapshot

When gen_snapshot encounters a url that has been remapped with the --url_mapping
command line argument it rewrites the library's url to be the mapped url before
canonicalization. The new C++ API only does canonicalization with respect to the
library's url (as returned by Dart_LibraryUrl) which is insufficient for
gen_snapshot. The correct long-term fix is to alter the new C++ API to allow for
the base url to be passed in directly rather than indirectly via
Dart_LibraryUrl.

This CL just restores some deleted code and has gen_snapshot work like it did
before. The standalone embedder still uses the C++ API during loading.
==========

[Cutch, 2016-06-02 21:51:49]

TBR

[Cutch, 2016-06-02 21:52:46]

Description was changed from

==========
Fix canonicalization of --url_mapping URIs in gen_snapshot

When gen_snapshot encounters a url that has been remapped with the --url_mapping
command line argument it rewrites the library's url to be the mapped url before
canonicalization. The new C++ API only does canonicalization with respect to the
library's url (as returned by Dart_LibraryUrl) which is insufficient for
gen_snapshot. The correct long-term fix is to alter the new C++ API to allow for
the base url to be passed in directly rather than indirectly via
Dart_LibraryUrl.

This CL just restores some deleted code and has gen_snapshot work like it did
before. The standalone embedder still uses the C++ API during loading.
==========

to

==========
Fix canonicalization of --url_mapping URIs in gen_snapshot

When gen_snapshot encounters a url that has been remapped with the --url_mapping
command line argument it rewrites the library's url to be the mapped url before
canonicalization. The new C++ API only does canonicalization with respect to the
library's url (as returned by Dart_LibraryUrl) which is insufficient for
gen_snapshot. The correct long-term fix is to alter the new C++ API to allow for
the base url to be passed in directly rather than indirectly via
Dart_LibraryUrl.

This CL just restores some deleted code and has gen_snapshot work like it did
before. The standalone embedder still uses the C++ API during loading.

Committed:
https://github.com/dart-lang/sdk/commit/d47866964cc6e3a6c00f50ab539f383408c78bf2
==========

[Cutch, 2016-06-02 21:52:47]

Committed patchset #1 (id:1) manually as
d47866964cc6e3a6c00f50ab539f383408c78bf2 (presubmit successful).

[Cutch, 2016-06-02 21:59:13]

Description was changed from

==========
Fix canonicalization of --url_mapping URIs in gen_snapshot

When gen_snapshot encounters a url that has been remapped with the --url_mapping
command line argument it rewrites the library's url to be the mapped url before
canonicalization. The new C++ API only does canonicalization with respect to the
library's url (as returned by Dart_LibraryUrl) which is insufficient for
gen_snapshot. The correct long-term fix is to alter the new C++ API to allow for
the base url to be passed in directly rather than indirectly via
Dart_LibraryUrl.

This CL just restores some deleted code and has gen_snapshot work like it did
before. The standalone embedder still uses the C++ API during loading.

Committed:
https://github.com/dart-lang/sdk/commit/d47866964cc6e3a6c00f50ab539f383408c78bf2
==========

to

==========
Fix canonicalization of --url_mapping URIs in gen_snapshot

When gen_snapshot encounters a url that has been remapped with the --url_mapping
command line argument it rewrites the library's url to be the mapped url before
canonicalization. The new C++ API only does canonicalization with respect to the
library's url (as returned by Dart_LibraryUrl) which is insufficient for
gen_snapshot. The correct long-term fix is to alter the new C++ API to allow for
the base url to be passed in directly rather than indirectly via
Dart_LibraryUrl.

This CL just restores some deleted code and has gen_snapshot work like it did
before. The standalone embedder still uses the C++ API during loading.

Dartium build failures:
https://build.chromium.org/p/client.dart/builders/dartium-mac-inc-be/builds/1...

Committed:
https://github.com/dart-lang/sdk/commit/d47866964cc6e3a6c00f50ab539f383408c78bf2
==========