Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: pkg/analyzer/lib/src/dart/element/element.dart

Issue 2031093002: Resynthesize ConstructorElement.redirectedConstructor lazily. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/element/element.dart
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index 636e0e995200fafd654dbb68c66c49e299c7aa45..7c1e056917cbf7af237cbf95e6229ffb651e92c1 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -1685,7 +1685,7 @@ class ConstructorElementImpl extends ExecutableElementImpl
/**
* The constructor to which this constructor is redirecting.
*/
- ConstructorElement redirectedConstructor;
+ ConstructorElement _redirectedConstructor;
/**
* The initializers for this constructor (used for evaluating constant
@@ -1756,7 +1756,8 @@ class ConstructorElementImpl extends ExecutableElementImpl
}
@override
- ClassElement get enclosingElement => super.enclosingElement as ClassElement;
+ ClassElementImpl get enclosingElement =>
+ super.enclosingElement as ClassElementImpl;
@override
TypeParameterizedElementMixin get enclosingTypeParameterContext =>
@@ -1855,6 +1856,30 @@ class ConstructorElementImpl extends ExecutableElementImpl
}
@override
+ ConstructorElement get redirectedConstructor {
+ if (serializedExecutable != null && _redirectedConstructor == null) {
+ if (serializedExecutable.isRedirectedConstructor) {
+ if (serializedExecutable.isFactory) {
+ _redirectedConstructor = enclosingUnit.resynthesizerContext
+ .resolveConstructorRef(
+ enclosingElement, serializedExecutable.redirectedConstructor);
+ } else {
+ _redirectedConstructor = enclosingElement.getNamedConstructor(
+ serializedExecutable.redirectedConstructorName);
+ }
+ } else {
+ return null;
+ }
+ }
+ return _redirectedConstructor;
+ }
+
+ void set redirectedConstructor(ConstructorElement redirectedConstructor) {
+ assert(serializedExecutable == null);
+ _redirectedConstructor = redirectedConstructor;
+ }
+
+ @override
DartType get returnType => enclosingElement.type;
@override
@@ -7369,6 +7394,13 @@ abstract class ResynthesizerContext {
UnitExplicitTopLevelVariables buildTopLevelVariables();
/**
+ * Resolve an [EntityRef] into a constructor. If the reference is
+ * unresolved, return `null`.
+ */
+ ConstructorElement resolveConstructorRef(
+ TypeParameterizedElementMixin typeParameterContext, EntityRef entry);
+
+ /**
* Build the appropriate [DartType] object corresponding to a slot id in the
* [LinkedUnit.types] table.
*/
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698