Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: BUILD.gn

Issue 2031063002: gn: Add all v8 targets to gn_all (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark gn_visibility testonly Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 35610ce68b48ff1294c3f9b1546440cb89a10afd..df1dc2b2da85af9f8546a8f240d2e5e88861bff4 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -784,6 +784,8 @@ group("gn_mojo_targets") {
}
group("gn_visibility") {
+ testonly = true
Michael Achenbach 2016/06/03 15:17:17 Not sure about marking this testonly. If I don't I
Dirk Pranke 2016/06/03 18:14:54 Marking this testonly is probably fine.
+
deps = [
"//build/config/sanitizers:options_sources",
# "//third_party/pdfium:pdfium_embeddertests", # TODO(GYP): visibility?
@@ -792,6 +794,7 @@ group("gn_visibility") {
if (!is_ios) {
deps += [
+ "//v8:gn_all",
Dirk Pranke 2016/06/03 18:14:54 This almost certainly shouldn't be part of "gn_vis
"//v8:postmortem-metadata",
"//v8:v8_snapshot",
]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698