Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h

Issue 2031053004: Reduce LayoutSVGResource*Gradient building dependency on GradientData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h
index 7727c46d55a84bb1a46d11d27f53bd3975503257..5f2bffcdea8e60390004d6bb206ca3504838f5ba 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h
@@ -50,14 +50,14 @@ public:
bool isChildAllowed(LayoutObject* child, const ComputedStyle&) const final;
protected:
- void addStops(GradientData*, const Vector<Gradient::ColorStop>&) const;
+ void addStops(Gradient&, const Vector<Gradient::ColorStop>&) const;
virtual SVGUnitTypes::SVGUnitType gradientUnits() const = 0;
- virtual void calculateGradientTransform(AffineTransform&) = 0;
+ virtual AffineTransform calculateGradientTransform() const = 0;
virtual bool collectGradientAttributes(SVGGradientElement*) = 0;
- virtual void buildGradient(GradientData*) const = 0;
+ virtual PassRefPtr<Gradient> buildGradient() const = 0;
- GradientSpreadMethod platformSpreadMethodFromSVGType(SVGSpreadMethodType) const;
+ static GradientSpreadMethod platformSpreadMethodFromSVGType(SVGSpreadMethodType);
private:
bool m_shouldCollectGradientAttributes : 1;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698