Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2031013002: Reland of expect_tests > coverage: no data, no fail (patchset #1 id:1 of https://codereview.chromium (Closed)

Created:
4 years, 6 months ago by Sergiy Byelozyorov
Modified:
4 years, 6 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/expect_tests.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : Original CL #

Patch Set 2 : Fixes #

Patch Set 3 : Addressed comments #

Patch Set 4 : Fix #

Total comments: 2

Patch Set 5 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M expect_tests/cover.py View 1 2 3 4 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Sergiy Byelozyorov
4 years, 6 months ago (2016-06-02 18:46:58 UTC) #1
tandrii(chromium)
https://codereview.chromium.org/2031013002/diff/1/expect_tests/cover.py File expect_tests/cover.py (right): https://codereview.chromium.org/2031013002/diff/1/expect_tests/cover.py#newcode119 expect_tests/cover.py:119: if ce.message == 'No data to report.': how about ...
4 years, 6 months ago (2016-06-02 18:53:00 UTC) #3
Sergiy Byelozyorov
On 2016/06/02 18:53:00, tandrii(chromium) wrote: > https://codereview.chromium.org/2031013002/diff/1/expect_tests/cover.py > File expect_tests/cover.py (right): > > https://codereview.chromium.org/2031013002/diff/1/expect_tests/cover.py#newcode119 > ...
4 years, 6 months ago (2016-06-02 18:58:34 UTC) #7
tandrii(chromium)
lgtm https://codereview.chromium.org/2031013002/diff/70001/expect_tests/cover.py File expect_tests/cover.py (right): https://codereview.chromium.org/2031013002/diff/70001/expect_tests/cover.py#newcode124 expect_tests/cover.py:124: print 'No data to report, setting coverage percentage ...
4 years, 6 months ago (2016-06-02 19:04:45 UTC) #9
Sergiy Byelozyorov
https://codereview.chromium.org/2031013002/diff/70001/expect_tests/cover.py File expect_tests/cover.py (right): https://codereview.chromium.org/2031013002/diff/70001/expect_tests/cover.py#newcode124 expect_tests/cover.py:124: print 'No data to report, setting coverage percentage to ...
4 years, 6 months ago (2016-06-02 19:05:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Reference: 2031013002/90001
4 years, 6 months ago (2016-06-02 19:05:20 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 19:05:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:90001) as
https://chromium.googlesource.com/infra/testing/expect_tests/+/fca8c5fcc66848...

Powered by Google App Engine
This is Rietveld 408576698