Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2030983002: Remove SK_SUPPORT_LEGACY_TYPEFACE_MAKE_FROM_NAME. (Closed)

Created:
4 years, 6 months ago by bungeman-skia
Modified:
4 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org, Mikus
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_SUPPORT_LEGACY_TYPEFACE_MAKE_FROM_NAME. The define SK_SUPPORT_LEGACY_TYPEFACE_MAKE_FROM_NAME is no longer used by any clients and the code it guards can now be removed as well. TBR=reed This just removes dead code. Committed: https://skia.googlesource.com/skia/+/da1aedaf1317c69fb249e2f5e37070b5dfa818e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M include/core/SkTypeface.h View 1 chunk +1 line, -13 lines 0 comments Download
M src/core/SkTypeface.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030983002/1
4 years, 6 months ago (2016-06-02 17:23:25 UTC) #4
bungeman-skia
4 years, 6 months ago (2016-06-02 17:30:32 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-02 17:42:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030983002/1
4 years, 6 months ago (2016-06-02 17:46:24 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 17:47:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/da1aedaf1317c69fb249e2f5e37070b5dfa818e2

Powered by Google App Engine
This is Rietveld 408576698