Fixup FPDFAvail_IsPageAvail checks in PDFiumEngine.

Fixup FPDFAvail_IsPageAvail checks in PDFiumEngine.

There are two issues with the use of FPDFAvail_IsPageAvail checks. First, we
need to compare the results against PDF_DATA_AVAIL and not just take the
negation as that means ERROR will mark the page as available.

Second, when we finish loading, we have to take the actual return value into
account instead of assuming the page is loaded correctly.

BUG=614211

[dsinclair, 2016-06-02 18:02:34]

Patchset #1 (id:1) has been deleted

[dsinclair, 2016-06-02 18:03:25]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org

[dsinclair, 2016-06-02 18:03:25]

PTAL.

https://codereview.chromium.org/2030953003/diff/20001/pdf/pdfium/pdfium_engin...
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/2030953003/diff/20001/pdf/pdfium/pdfium_engin...
pdf/pdfium/pdfium_engine.cc:1102: while (true) {
This is probably bad, and I feel bad, but I wasn't sure the correct solution
....

[dsinclair, 2016-06-07 13:32:03]

On 2016/06/02 18:03:25, dsinclair wrote:
> PTAL.
> 
>
https://codereview.chromium.org/2030953003/diff/20001/pdf/pdfium/pdfium_engin...
> File pdf/pdfium/pdfium_engine.cc (right):
> 
>
https://codereview.chromium.org/2030953003/diff/20001/pdf/pdfium/pdfium_engin...
> pdf/pdfium/pdfium_engine.cc:1102: while (true) {
> This is probably bad, and I feel bad, but I wasn't sure the correct solution
> ....

Ping. Looks like there are a few broken tests, but would like to know if the
direction of this CL is right before digging into the issues.

[Lei Zhang, 2016-06-08 02:06:19]

On 2016/06/07 13:32:03, dsinclair wrote:
> On 2016/06/02 18:03:25, dsinclair wrote:
> > PTAL.
> > 
> >
>
https://codereview.chromium.org/2030953003/diff/20001/pdf/pdfium/pdfium_engin...
> > File pdf/pdfium/pdfium_engine.cc (right):
> > 
> >
>
https://codereview.chromium.org/2030953003/diff/20001/pdf/pdfium/pdfium_engin...
> > pdf/pdfium/pdfium_engine.cc:1102: while (true) {
> > This is probably bad, and I feel bad, but I wasn't sure the correct solution
> > ....
> 
> Ping. Looks like there are a few broken tests, but would like to know if the
> direction of this CL is right before digging into the issues.

I suspect some of the tests may be failing because they are stuck in an infinite
loop. Let me think about this and get back to you.

[dsinclair, 2016-06-08 02:07:57]

On 2016/06/08 02:06:19, Lei Zhang (Slow) wrote:
> On 2016/06/07 13:32:03, dsinclair wrote:
> > On 2016/06/02 18:03:25, dsinclair wrote:
> > > PTAL.
> > > 
> > >
> >
>
https://codereview.chromium.org/2030953003/diff/20001/pdf/pdfium/pdfium_engin...
> > > File pdf/pdfium/pdfium_engine.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2030953003/diff/20001/pdf/pdfium/pdfium_engin...
> > > pdf/pdfium/pdfium_engine.cc:1102: while (true) {
> > > This is probably bad, and I feel bad, but I wasn't sure the correct
solution
> > > ....
> > 
> > Ping. Looks like there are a few broken tests, but would like to know if the
> > direction of this CL is right before digging into the issues.
> 
> I suspect some of the tests may be failing because they are stuck in an
infinite
> loop. Let me think about this and get back to you.


Is the problem that the test is bad in that case since the data doesn't become
available?

[Lei Zhang, 2016-06-08 07:11:18]

I tried to check the FPDFAvail_IsPageAvail() results in
https://codereview.chromium.org/1550193002/ and ran into trouble as well. While
this is something we should fix, I don't think it's the cause of your bug. I'll
post a PDFium CL shortly for the bug.

As for FPDFAvail_IsPageAvail(), I suspect we should accept the error result if
the document is not linearized. Maybe we don't even need to call it for
non-linearized docs.

[Lei Zhang, 2016-06-08 07:34:44]

On 2016/06/08 07:11:18, Lei Zhang (Slow) wrote:
> I tried to check the FPDFAvail_IsPageAvail() results in
> https://codereview.chromium.org/1550193002/ and ran into trouble as well.
While
> this is something we should fix, I don't think it's the cause of your bug.
I'll
> post a PDFium CL shortly for the bug.

"shortly" -> https://codereview.chromium.org/2045013004/