Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 2030913002: Revert of Stopped WebVR from being partially enabled during testing. (Closed)

Created:
4 years, 6 months ago by vabr (Chromium)
Modified:
4 years, 6 months ago
Reviewers:
esprehn, bajones
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2029843002/ ) Reason for revert: Speculative revert, may have broken FormAutofillTest.WebFormElementToFormDataTooManyFields on ASAN bots. For more info see: BUG=616730 Original issue's description: > Stopped WebVR from being partially enabled during testing. > > Should prevent repeated instances of "blink::mojom::VRService not found" in test > logs. > > BUG=614752 > > Committed: https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a > Cr-Commit-Position: refs/heads/master@{#397335} TBR=esprehn@chromium.org,bajones@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=614752 Committed: https://crrev.com/8d4d2467316e320d44d59db7113d6474549bf617 Cr-Commit-Position: refs/heads/master@{#397372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/child/runtime_features.cc View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vabr (Chromium)
Created Revert of Stopped WebVR from being partially enabled during testing.
4 years, 6 months ago (2016-06-02 11:53:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030913002/1
4 years, 6 months ago (2016-06-02 11:53:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 11:53:58 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8d4d2467316e320d44d59db7113d6474549bf617 Cr-Commit-Position: refs/heads/master@{#397372}
4 years, 6 months ago (2016-06-02 11:55:43 UTC) #7
vabr (Chromium)
4 years, 6 months ago (2016-06-02 11:58:08 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2030023002/ by vabr@chromium.org.

The reason for reverting is: This revert was speculative and the test proved to
be too flaky for the revert results to be conclusive.

Sorry for the noise, relanding..

Powered by Google App Engine
This is Rietveld 408576698