Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2030883002: Rename FrameFetchContext::ensureLoaderForNotifications. (Closed)

Created:
4 years, 6 months ago by engedy
Modified:
4 years, 6 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename FrameFetchContext::ensureLoaderForNotifications. Rename the helper method |ensureLoaderForNotifications| to |masterDocumentLoader| in FrameFetchContext. This makes it consistent with terminology coined in https://www.w3.org/TR/html-imports/, and removes the confusion introduced by using the `ensure` prefix even though the method did not exhibit "create-if-not-exists" behavior. BUG=274173 Committed: https://crrev.com/4865c279c5c0fa018f1b5fc0f1374c71c987f9bb Cr-Commit-Position: refs/heads/master@{#397375}

Patch Set 1 #

Patch Set 2 : Updated comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M third_party/WebKit/Source/core/loader/FrameFetchContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 5 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
engedy
Mike, please take a look.
4 years, 6 months ago (2016-06-02 10:26:59 UTC) #4
Mike West
LGTM.
4 years, 6 months ago (2016-06-02 12:24:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030883002/40001
4 years, 6 months ago (2016-06-02 12:26:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-02 12:29:16 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 12:30:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4865c279c5c0fa018f1b5fc0f1374c71c987f9bb
Cr-Commit-Position: refs/heads/master@{#397375}

Powered by Google App Engine
This is Rietveld 408576698