Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 2030873002: Mojo C++ bindings: rename ArrayValidateParams for clarity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cc-enums
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/generators/mojom_cpp_generator.py
diff --git a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py
index 357c831e640c58bae140d72dd43a522efcf8dc0f..e2b7ee5e1c63b6de682c808593c3a534ac4214ce 100644
--- a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py
+++ b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py
@@ -379,7 +379,7 @@ def ShouldInlineStruct(struct):
def ShouldInlineUnion(union):
return not any(mojom.IsMoveOnlyKind(field.kind) for field in union.fields)
-def GetArrayValidateParamsCtorArgs(kind):
+def GetContainerValidateParamsCtorArgs(kind):
if mojom.IsStringKind(kind):
expected_num_elements = 0
element_is_nullable = False
@@ -389,16 +389,16 @@ def GetArrayValidateParamsCtorArgs(kind):
elif mojom.IsMapKind(kind):
expected_num_elements = 0
element_is_nullable = False
- key_validate_params = GetNewArrayValidateParams(mojom.Array(
+ key_validate_params = GetNewContainerValidateParams(mojom.Array(
kind=kind.key_kind))
- element_validate_params = GetNewArrayValidateParams(mojom.Array(
+ element_validate_params = GetNewContainerValidateParams(mojom.Array(
kind=kind.value_kind))
enum_validate_func = "nullptr"
else: # mojom.IsArrayKind(kind)
expected_num_elements = generator.ExpectedArraySize(kind) or 0
element_is_nullable = mojom.IsNullableKind(kind.kind)
key_validate_params = "nullptr"
- element_validate_params = GetNewArrayValidateParams(kind.kind)
+ element_validate_params = GetNewContainerValidateParams(kind.kind)
if mojom.IsEnumKind(kind.kind):
enum_validate_func = ("%s::Validate" %
GetQualifiedNameForKind(kind.kind, internal=True))
@@ -415,13 +415,13 @@ def GetArrayValidateParamsCtorArgs(kind):
else:
return "%d, %s" % (expected_num_elements, enum_validate_func)
-def GetNewArrayValidateParams(kind):
+def GetNewContainerValidateParams(kind):
if (not mojom.IsArrayKind(kind) and not mojom.IsMapKind(kind) and
not mojom.IsStringKind(kind)):
return "nullptr"
- return "new mojo::internal::ArrayValidateParams(%s)" % (
- GetArrayValidateParamsCtorArgs(kind))
+ return "new mojo::internal::ContainerValidateParams(%s)" % (
+ GetContainerValidateParamsCtorArgs(kind))
class Generator(generator.Generator):
@@ -435,7 +435,7 @@ class Generator(generator.Generator):
"cpp_wrapper_type": GetCppWrapperType,
"default_value": DefaultValue,
"expression_to_text": ExpressionToText,
- "get_array_validate_params_ctor_args": GetArrayValidateParamsCtorArgs,
+ "get_array_validate_params_ctor_args": GetContainerValidateParamsCtorArgs,
yzshen1 2016/06/02 19:57:03 please update get_array_validate_params_ctor_args
tibell 2016/06/03 00:01:30 Done.
"get_name_for_kind": GetNameForKind,
"get_pad": pack.GetPad,
"get_qualified_name_for_kind": GetQualifiedNameForKind,

Powered by Google App Engine
This is Rietveld 408576698