Web Animations: Account for end delay in after phase active time

third_party/WebKit/Source/core/animation/TimingCalculationsTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 79 matching lines @@
 
     // infinte activeTime
     timing.playbackRate = 0;
     EXPECT_EQ(0, calculateScaledActiveTime(std::numeric_limits<double>::infinity(), std::numeric_limits<double>::infinity(), 0, timing));
     timing.playbackRate = 1;
     EXPECT_EQ(std::numeric_limits<double>::infinity(), calculateScaledActiveTime(std::numeric_limits<double>::infinity(), std::numeric_limits<double>::infinity(), 0, timing));
     timing.playbackRate = -1;
     EXPECT_EQ(std::numeric_limits<double>::infinity(), calculateScaledActiveTime(std::numeric_limits<double>::infinity(), std::numeric_limits<double>::infinity(), 0, timing));
 }
 
 TEST(AnimationTimingCalculationsTest, IterationTime)

[suzyh_UTC10 (ex-contributor), 2016/07/25 00:51:09]

This test is confusing and not easy to read, so let's leave it better than we
found it. Perhaps split it up into several tests for the different conditions?
Probably a good idea to add tests for different values for the phase argument as
well, now that that's possible.

[suzyh_UTC10 (ex-contributor), 2016/07/25 01:52:12]

Ping on this. I suspect this comment got lost because it is on a line that
codereview is not automatically showing.

[alancutter (OOO until 2018), 2016/07/25 04:46:48]

I think it's not a good use of time to rewrite these unit tests when the code
itself is in need of a rewrite to be more aligned with the spec.
It's difficult to even know what's expected of code that doesn't have a clear
specification.

[suzyh_UTC10 (ex-contributor), 2016/07/25 04:55:23]

OK. Make a note in the rewrite bug you filed and/or add a TODO here.

[alancutter (OOO until 2018), 2016/07/26 00:49:39]

The unit tests will be rewritten as part of rewriting the code, no need to add a
TODO to do so.

 {
     Timing timing;
 
-    // calculateIterationTime(iterationDuration, repeatedDuration, scaledActiveTime, startOffset, timing)
+    // calculateIterationTime(iterationDuration, repeatedDuration, scaledActiveTime, startOffset, phase, timing)
 
     // if the scaled active time is null
-    EXPECT_TRUE(isNull(calculateIterationTime(1, 1, nullValue(), 1, timing)));
+    EXPECT_TRUE(isNull(calculateIterationTime(1, 1, nullValue(), 1, AnimationEffect::PhaseActive, timing)));
 
     // if (complex-conditions)...
-    EXPECT_EQ(12, calculateIterationTime(12, 12, 12, 0, timing));
+    EXPECT_EQ(12, calculateIterationTime(12, 12, 12, 0, AnimationEffect::PhaseActive, timing));
 
     // otherwise
     timing.iterationCount = 10;
-    EXPECT_EQ(5, calculateIterationTime(10, 100, 25, 4, timing));
-    EXPECT_EQ(7, calculateIterationTime(11, 110, 29, 1, timing));
+    EXPECT_EQ(5, calculateIterationTime(10, 100, 25, 4, AnimationEffect::PhaseActive, timing));
+    EXPECT_EQ(7, calculateIterationTime(11, 110, 29, 1, AnimationEffect::PhaseActive, timing));
     timing.iterationStart = 1.1;
-    EXPECT_EQ(8, calculateIterationTime(12, 120, 20, 7, timing));
+    EXPECT_EQ(8, calculateIterationTime(12, 120, 20, 7, AnimationEffect::PhaseActive, timing));
 }
 
 TEST(AnimationTimingCalculationsTest, CurrentIteration)
 {
     Timing timing;
 
     // calculateCurrentIteration(iterationDuration, iterationTime, scaledActiveTime, timing)
 
     // if the scaled active time is null
     EXPECT_TRUE(isNull(calculateCurrentIteration(1, 1, nullValue(), timing)));
@@ skipping 76 matching lines @@
     // Timing function when iterationDuration is infinity
     timing.direction = Timing::PlaybackDirectionNormal;
     EXPECT_EQ(0, calculateTransformedTime(0, std::numeric_limits<double>::infinity(), 0, timing));
     EXPECT_EQ(1, calculateTransformedTime(0, std::numeric_limits<double>::infinity(), 1, timing));
     timing.direction = Timing::PlaybackDirectionReverse;
     EXPECT_EQ(std::numeric_limits<double>::infinity(), calculateTransformedTime(0, std::numeric_limits<double>::infinity(), 0, timing));
     EXPECT_EQ(std::numeric_limits<double>::infinity(), calculateTransformedTime(0, std::numeric_limits<double>::infinity(), 1, timing));
 }
 
 } // namespace blink