third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/AnimationEffectTiming/getComputedStyle-expected.txt - Issue 2030843002: Web Animations: Account for end delay in after phase active time

Side by Side Diff: third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/AnimationEffectTiming/getComputedStyle-expected.txt

Issue 2030843002: Web Animations: Account for end delay in after phase active time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html » ('j') | third_party/WebKit/LayoutTests/web-animations-api/fill-forward-negative-end-delay.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 This is a testharness.js-based test.

	2 PASS changed duration immediately updates its computed styles

	3 PASS changed iterations immediately updates its computed styles

	4 PASS change currentTime when fill is none and endDelay is positive

	5 PASS change currentTime when fill forwards and endDelay is positive

	6 PASS change currentTime when fill none and endDelay is negative

	7 FAIL change currentTime when fill forwards and endDelay is negative assert_equal s: set currentTime same as endTime expected "0" but got "0.5"
	suzyh_UTC10 (ex-contributor) 2016/07/25 00:51:09 Is this an error in the upstream test? Is this an error in the upstream test? alancutter (OOO until 2018) 2016/07/25 01:44:32 Yes. Show quoted text On 2016/07/25 at 00:51:09, suzyh wrote: > Is this an error in the upstream test? Yes. suzyh_UTC10 (ex-contributor) 2016/07/25 01:52:12 I recommend fixing the upstream test in the same p Show quoted text On 2016/07/25 at 01:44:32, alancutter wrote: > On 2016/07/25 at 00:51:09, suzyh wrote: > > Is this an error in the upstream test? > > Yes. I recommend fixing the upstream test in the same pull request as adding the additional test below. alancutter (OOO until 2018) 2016/07/25 04:46:48 Would the change get upstreamed? I'm not sure I se Show quoted text On 2016/07/25 at 01:52:12, suzyh wrote: > On 2016/07/25 at 01:44:32, alancutter wrote: > > On 2016/07/25 at 00:51:09, suzyh wrote: > > > Is this an error in the upstream test? > > > > Yes. > > I recommend fixing the upstream test in the same pull request as adding the additional test below. Would the change get upstreamed? I'm not sure I see any reason to modify our copy of it if not. suzyh_UTC10 (ex-contributor) 2016/07/25 04:55:23 No, I meant to make the change upstream (since you Show quoted text On 2016/07/25 at 04:46:48, alancutter wrote: > On 2016/07/25 at 01:52:12, suzyh wrote: > > On 2016/07/25 at 01:44:32, alancutter wrote: > > > On 2016/07/25 at 00:51:09, suzyh wrote: > > > > Is this an error in the upstream test? > > > > > > Yes. > > > > I recommend fixing the upstream test in the same pull request as adding the additional test below. > > Would the change get upstreamed? I'm not sure I see any reason to modify our copy of it if not. No, I meant to make the change upstream (since you're already intending to upstream fill-forward-negative-end-delay.html anyway), not to modify our copy. alancutter (OOO until 2018) 2016/07/26 00:49:39 Whoops, confused PR for CL. Show quoted text On 2016/07/25 at 04:55:23, suzyh wrote: > On 2016/07/25 at 04:46:48, alancutter wrote: > > On 2016/07/25 at 01:52:12, suzyh wrote: > > > On 2016/07/25 at 01:44:32, alancutter wrote: > > > > On 2016/07/25 at 00:51:09, suzyh wrote: > > > > > Is this an error in the upstream test? > > > > > > > > Yes. > > > > > > I recommend fixing the upstream test in the same pull request as adding the additional test below. > > > > Would the change get upstreamed? I'm not sure I see any reason to modify our copy of it if not. > > No, I meant to make the change upstream (since you're already intending to upstream fill-forward-negative-end-delay.html anyway), not to modify our copy. Whoops, confused PR for CL.
	8 PASS change direction from "normal" to "reverse"

	9 PASS change direction from "normal" to "alternate"

	10 PASS change direction from "normal" to "alternate-reverse"

	11 PASS change direction from "normal" to "reverse"

	12 Harness: the test ran to completion.

	13

OLD	NEW