|
|
Created:
4 years, 6 months ago by Dirk Pranke Modified:
4 years, 6 months ago Reviewers:
brucedawson CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip more Win bots to GN.
This flips the remaining Win builders on the chromium, chromium.chrome,
and chromium.perf waterfalls, as well as the matching trybots. The
remaining GYP win builders are FYI bots, memory bots, and the official
builders; the latter should be flipped ASAP after this lands to avoid
any skew.
R=brucedawson@chromium.org
BUG=605319
Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
Cr-Commit-Position: refs/heads/master@{#398033}
Patch Set 1 #
Messages
Total messages: 20 (8 generated)
On 2016/06/02 02:18:58, Dirk Pranke wrote: From the win_archive builder: > v8\test\cctest\compiler\test-run-load-store.cc(391): warning C4309: 'static_cast': truncation of constant value I've been hitting these locally. I'll create a fix. So far I've been unable to figure out what changed to make them start happening, but maybe I don't care.
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030823002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
If the bots pass now (they should?) then lgtm.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030823002/1
The CQ bit was unchecked by dpranke@chromium.org
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030823002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030823002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Flip more Win bots to GN. This flips the remaining Win builders on the chromium, chromium.chrome, and chromium.perf waterfalls, as well as the matching trybots. The remaining GYP win builders are FYI bots, memory bots, and the official builders; the latter should be flipped ASAP after this lands to avoid any skew. R=brucedawson@chromium.org BUG=605319 ========== to ========== Flip more Win bots to GN. This flips the remaining Win builders on the chromium, chromium.chrome, and chromium.perf waterfalls, as well as the matching trybots. The remaining GYP win builders are FYI bots, memory bots, and the official builders; the latter should be flipped ASAP after this lands to avoid any skew. R=brucedawson@chromium.org BUG=605319 Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824 Cr-Commit-Position: refs/heads/master@{#398033} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824 Cr-Commit-Position: refs/heads/master@{#398033}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2046913002/ by kinuko@chromium.org. The reason for reverting is: Suspected to break Chrome Win builder. (Will revert this revert if it was a false alarm) Error log: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b... C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome chrome_official_builder_no_unittests -j200 ninja: Entering directory `C:\b\build\slave\google-chrome-rel-win\build\src\out\Release' ninja: error: unknown target 'chrome_official_builder_no_unittests'. |