Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2030823002: Flip more Win bots to GN. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip more Win bots to GN. This flips the remaining Win builders on the chromium, chromium.chrome, and chromium.perf waterfalls, as well as the matching trybots. The remaining GYP win builders are FYI bots, memory bots, and the official builders; the latter should be flipped ASAP after this lands to avoid any skew. R=brucedawson@chromium.org BUG=605319 Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824 Cr-Commit-Position: refs/heads/master@{#398033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M tools/mb/mb_config.pyl View 7 chunks +19 lines, -15 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-02 02:18:58 UTC) #1
brucedawson
On 2016/06/02 02:18:58, Dirk Pranke wrote: From the win_archive builder: > v8\test\cctest\compiler\test-run-load-store.cc(391): warning C4309: 'static_cast': ...
4 years, 6 months ago (2016-06-02 20:13:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030823002/1
4 years, 6 months ago (2016-06-03 18:18:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 19:26:20 UTC) #6
brucedawson
If the bots pass now (they should?) then lgtm.
4 years, 6 months ago (2016-06-03 19:44:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030823002/1
4 years, 6 months ago (2016-06-06 03:15:49 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030823002/1
4 years, 6 months ago (2016-06-06 03:16:09 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 04:46:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030823002/1
4 years, 6 months ago (2016-06-06 15:38:15 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 15:43:24 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824 Cr-Commit-Position: refs/heads/master@{#398033}
4 years, 6 months ago (2016-06-06 15:46:03 UTC) #19
kinuko
4 years, 6 months ago (2016-06-07 08:20:11 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2046913002/ by kinuko@chromium.org.

The reason for reverting is: Suspected to break Chrome Win builder. (Will revert
this revert if it was a false alarm)

Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C
C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome
chrome_official_builder_no_unittests -j200
ninja: Entering directory
`C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'.

Powered by Google App Engine
This is Rietveld 408576698