Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1841)

Unified Diff: chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc

Issue 2030803002: Fix newly introduced flake in ExtensionPreferenceApiTest.Standard (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc
diff --git a/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc b/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc
index 6f0a87f2ffd673db41e741f2e6ead3b156e8cdc8..816ed0addcc36e7a4ec0abe1786e530bd97fee58 100644
--- a/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc
+++ b/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc
@@ -51,7 +51,11 @@ void AutofillPrivateEventRouter::Shutdown() {
}
void AutofillPrivateEventRouter::OnPersonalDataChanged() {
- DCHECK(personal_data_ && personal_data_->IsDataLoaded());
+ DCHECK(personal_data_);
stevenjb 2016/06/08 00:25:53 Looking at personal_data_manager.cc, it is not cle
hcarmona 2016/06/08 14:21:06 Done.
+
+ // Ignore any updates before data is loaded. This can happen in tests.
+ if (!personal_data_->IsDataLoaded())
+ return;
autofill_util::AddressEntryList addressList =
extensions::autofill_util::GenerateAddressList(*personal_data_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698