Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2030803002: Fix newly introduced flake in ExtensionPreferenceApiTest.Standard (Closed)

Created:
4 years, 6 months ago by hcarmona
Modified:
4 years, 6 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix newly introduced flake in ExtensionPreferenceApiTest.Standard BUG=614552 Committed: https://crrev.com/954b89348444571c3b369fc0e2fe98619b9c64c1 Cr-Commit-Position: refs/heads/master@{#398997}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
hcarmona
PTAL, Thanks!
4 years, 6 months ago (2016-06-02 01:16:12 UTC) #2
stevenjb
https://codereview.chromium.org/2030803002/diff/1/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc File chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc (right): https://codereview.chromium.org/2030803002/diff/1/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc#newcode54 chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc:54: DCHECK(personal_data_); Looking at personal_data_manager.cc, it is not clear to ...
4 years, 6 months ago (2016-06-08 00:25:53 UTC) #3
hcarmona
https://codereview.chromium.org/2030803002/diff/1/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc File chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc (right): https://codereview.chromium.org/2030803002/diff/1/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc#newcode54 chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc:54: DCHECK(personal_data_); On 2016/06/08 00:25:53, stevenjb wrote: > Looking at ...
4 years, 6 months ago (2016-06-08 14:21:06 UTC) #4
stevenjb
lgtm
4 years, 6 months ago (2016-06-09 17:46:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030803002/20001
4 years, 6 months ago (2016-06-09 18:17:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 20:26:18 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 20:26:19 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 20:29:07 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/954b89348444571c3b369fc0e2fe98619b9c64c1
Cr-Commit-Position: refs/heads/master@{#398997}

Powered by Google App Engine
This is Rietveld 408576698