components/offline_pages/snapshot_controller.cc - Issue 2030793002: Remove overeager DCHECK in SnapshotController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/snapshot_controller.cc

Issue 2030793002: Remove overeager DCHECK in SnapshotController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/snapshot_controller.cc

diff --git a/components/offline_pages/snapshot_controller.cc b/components/offline_pages/snapshot_controller.cc

index 374b9f561119b3fcb9feadfe97d591ae6d7c8940..ace25101b5f1c8c49dc99a4997e44a70538f1af5 100644

--- a/components/offline_pages/snapshot_controller.cc

+++ b/components/offline_pages/snapshot_controller.cc

@@ -45,7 +45,6 @@ void SnapshotController::PendingSnapshotCompleted() {

// Stopped state prevents any further snapshots form being started.

if (state_ == State::kStopped)

return;

- DCHECK(state_ == State::kSnapshotPending);

state_ = State::kReady;

}