Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2030783002: Remove inactive accounts from OWNERS: armansito, keybuk, rpaquay (Closed)

Created:
4 years, 6 months ago by scheib
Modified:
4 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, hashimoto+watch_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove inactive accounts from OWNERS: armansito, keybuk, rpaquay These individuals are no longer performing reviews or submitting code in the Chromium repository. Being in the OWNERS files confuses tools such as git cl owners. Committed: https://crrev.com/4558d7efd9ce7eb7bd04cce5a442baabc5d4b24b Cr-Commit-Position: refs/heads/master@{#398938}

Patch Set 1 #

Total comments: 5

Patch Set 2 : use apps owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -34 lines) Patch
M chrome/browser/chromeos/dbus/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/dbus/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
M dbus/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M device/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D device/nfc/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M device/usb/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/bluetooth/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D extensions/browser/api/bluetooth_socket/OWNERS View 1 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/api/hid/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/serial/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/socket/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/browser/api/sockets_tcp/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
D extensions/browser/api/sockets_tcp_server/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
D extensions/browser/api/sockets_udp/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
D extensions/browser/api/system_network/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/usb/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (7 generated)
scheib
rockot: chrome/browser/extensions/api/bluetooth_low_energy/OWNERS device/OWNERS device/nfc/OWNERS device/usb/OWNERS extensions/browser/api/bluetooth/OWNERS extensions/browser/api/bluetooth_socket/OWNERS extensions/browser/api/hid/OWNERS extensions/browser/api/serial/OWNERS extensions/browser/api/socket/OWNERS extensions/browser/api/sockets_tcp/OWNERS extensions/browser/api/sockets_tcp_server/OWNERS extensions/browser/api/sockets_udp/OWNERS extensions/browser/api/system_network/OWNERS extensions/browser/api/usb/OWNERS ...
4 years, 6 months ago (2016-06-02 00:13:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030783002/1
4 years, 6 months ago (2016-06-03 17:15:41 UTC) #3
scheib
rockot: chrome/browser/extensions/api/bluetooth_low_energy/OWNERS device/OWNERS device/nfc/OWNERS device/usb/OWNERS extensions/browser/api/bluetooth/OWNERS extensions/browser/api/bluetooth_socket/OWNERS extensions/browser/api/hid/OWNERS extensions/browser/api/serial/OWNERS extensions/browser/api/socket/OWNERS extensions/browser/api/sockets_tcp/OWNERS extensions/browser/api/sockets_tcp_server/OWNERS extensions/browser/api/sockets_udp/OWNERS extensions/browser/api/system_network/OWNERS extensions/browser/api/usb/OWNERS ...
4 years, 6 months ago (2016-06-03 17:16:00 UTC) #5
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-03 17:19:05 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 18:07:01 UTC) #8
stevenjb
Please pick *someone* to own the extension APIs; the top level owners are not going ...
4 years, 6 months ago (2016-06-08 01:09:11 UTC) #9
scheib
xiyuan@chromium.org & rdevlin.cronin@chromium.org, you both own Chrome Apps and Chrome Extensions respectively. Some of these ...
4 years, 6 months ago (2016-06-08 20:52:27 UTC) #11
Devlin
On 2016/06/08 20:52:27, scheib wrote: > mailto:xiyuan@chromium.org & mailto:rdevlin.cronin@chromium.org, you both own Chrome Apps and ...
4 years, 6 months ago (2016-06-08 23:03:14 UTC) #12
stevenjb
I don't have a better solution. sgtm. On Wed, Jun 8, 2016 at 4:03 PM, ...
4 years, 6 months ago (2016-06-08 23:05:45 UTC) #13
scheib
Apps APIs now use apps/OWNERS.
4 years, 6 months ago (2016-06-09 04:02:06 UTC) #14
Devlin
lgtm
4 years, 6 months ago (2016-06-09 17:05:58 UTC) #15
stevenjb
On 2016/06/09 17:05:58, Devlin wrote: > lgtm Thanks! lgtm
4 years, 6 months ago (2016-06-09 17:08:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030783002/20001
4 years, 6 months ago (2016-06-09 17:38:20 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 17:45:59 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 17:46:27 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 17:49:15 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4558d7efd9ce7eb7bd04cce5a442baabc5d4b24b
Cr-Commit-Position: refs/heads/master@{#398938}

Powered by Google App Engine
This is Rietveld 408576698