components/offline_pages/background/request_coordinator.cc - Issue 2030773002: Add unit tests for the Background Scheduler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2030773002: Add unit tests for the Background Scheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR feedback per DougArnett Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/request_coordinator.cc

diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc

index 940b3e7f29f1e45c8863fe00a326bdd34cd7b28d..6b1e63e46a67324610b1993da9d41f24714a3265 100644

--- a/components/offline_pages/background/request_coordinator.cc

+++ b/components/offline_pages/background/request_coordinator.cc

@@ -96,6 +96,7 @@ void RequestCoordinator::StopProcessing() {

}

void RequestCoordinator::SendRequestToOffliner(const SavePageRequest& request) {

+ // TODO(petewil): Ensure only one offliner at a time is used.

// TODO(petewil): When we have multiple offliners, we need to pick one.

Offliner* offliner = factory_->GetOffliner(policy_.get());

if (!offliner) {