Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java

Issue 2030773002: Add unit tests for the Background Scheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per DougArnett Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java
index 6603df8172938480ddf9e64671d9ec33f5c8be52..9cde885475376399dc7fbb1a592c38fe85b7cdab 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java
@@ -6,7 +6,6 @@ package org.chromium.chrome.browser.offlinepages;
import android.content.Context;
import android.os.Bundle;
-import android.os.SystemClock;
import com.google.android.gms.gcm.GcmNetworkManager;
import com.google.android.gms.gcm.OneoffTask;
@@ -18,8 +17,6 @@ import org.chromium.chrome.browser.ChromeBackgroundService;
* The background scheduler class is for setting GCM Network Manager tasks.
*/
public class BackgroundScheduler {
- /** Bundle key for the timestamp in milliseconds when the request started. */
- public static final String DATE_TAG = "Date";
private static final long ONE_WEEK_IN_SECONDS = 60 * 60 * 24 * 7;
/**
@@ -29,13 +26,11 @@ public class BackgroundScheduler {
// Get the GCM Network Scheduler.
GcmNetworkManager gcmNetworkManager = GcmNetworkManager.getInstance(context);
- // TODO(petewil): Move the bundle packing and unpacking into a new SchedulerBridge
- // class which can be mocked, and calls the static BackgroundSchdeulerBridge.
// TODO(petewil): Add the triggering conditions into the argument bundle.
// Triggering conditions will include network state and charging requirements, maybe
// also battery percentage.
Bundle taskExtras = new Bundle();
- taskExtras.putLong(DATE_TAG, SystemClock.elapsedRealtime());
+ TaskExtrasPacker.packTimeInBundle(taskExtras);
Task task = new OneoffTask.Builder()
.setService(ChromeBackgroundService.class)
@@ -45,6 +40,7 @@ public class BackgroundScheduler {
.setRequiredNetwork(Task.NETWORK_STATE_CONNECTED)
.setRequiresCharging(false)
.setExtras(taskExtras)
+ .setPersisted(true)
dewittj 2016/06/03 21:21:49 This should be done in a separate CL - not related
Pete Williamson 2016/06/03 22:14:18 Done.
.build();
gcmNetworkManager.schedule(task);

Powered by Google App Engine
This is Rietveld 408576698