Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2030773002: Add unit tests for the Background Scheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable flaky test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index efd467089f2659c31f0bd4dd7c1a0b62cc8569d9..a6001a04b6e0d9991bbf1a17ff0dcef48122aa8e 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -29,7 +29,6 @@ class Scheduler;
class RequestCoordinator : public KeyedService {
public:
// Callback to report when the processing of a triggered task is complete.
- typedef base::Callback<void()> ProcessingDoneCallback;
typedef base::Callback<void(const SavePageRequest& request)>
RequestPickedCallback;
typedef base::Callback<void()> RequestQueueEmptyCallback;
@@ -48,7 +47,7 @@ class RequestCoordinator : public KeyedService {
// Starts processing of one or more queued save page later requests.
// Returns whether processing was started and that caller should expect
// a callback. If processing was already active, returns false.
- bool StartProcessing(const ProcessingDoneCallback& callback);
+ bool StartProcessing(const base::Callback<void(bool)>& callback);
// Stops the current request processing if active. This is a way for
// caller to abort processing; otherwise, processing will complete on

Powered by Google App Engine
This is Rietveld 408576698