components/offline_pages/background/request_coordinator.h - Issue 2030773002: Add unit tests for the Background Scheduler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2030773002: Add unit tests for the Background Scheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Callback<Boolean> and BackgroundSchedulerProcessor Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/request_coordinator.h

diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h

index efd467089f2659c31f0bd4dd7c1a0b62cc8569d9..feeab6367e6ac71e22b98919a4ff4e884f8463dd 100644

--- a/components/offline_pages/background/request_coordinator.h

+++ b/components/offline_pages/background/request_coordinator.h

@@ -48,7 +48,7 @@ class RequestCoordinator : public KeyedService {

// Starts processing of one or more queued save page later requests.

// Returns whether processing was started and that caller should expect

// a callback. If processing was already active, returns false.

- bool StartProcessing(const ProcessingDoneCallback& callback);

+ bool StartProcessing(const base::Callback<void(bool)> callback);

Bernhard Bauer 2016/06/08 14:09:29 I would still pass the callback by (const) referen

Pete Williamson 2016/06/08 17:43:28 Done.

// Stops the current request processing if active. This is a way for

// caller to abort processing; otherwise, processing will complete on