chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java - Issue 2030773002: Add unit tests for the Background Scheduler.

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java

Issue 2030773002: Add unit tests for the Background Scheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/offlinepages/interfaces/SchedulerBridgeInterface.java ('K') | « chrome/android/java_sources.gni ('k') | chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java

index 75c98108bec0dd1c0e1de0fd731d21a374866acf..f0d905d520efedac01d3a88182a57552538f0be2 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java

@@ -15,6 +15,7 @@ import org.chromium.base.metrics.RecordHistogram;

import org.chromium.base.test.util.AdvancedMockContext;

import org.chromium.base.test.util.Feature;

import org.chromium.chrome.browser.ntp.snippets.SnippetsLauncher;

+import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;

import org.chromium.chrome.browser.precache.PrecacheController;

/**

@@ -187,4 +188,10 @@ public class ChromeBackgroundServiceTest extends InstrumentationTestCase {

mTaskService.deletePrecacheInstance();

startOnRunTaskAndVerify(PrecacheController.PERIODIC_TASK_TAG, true, true, false, false);

}

+ @SmallTest

+ @Feature({"BackgroundOfflining"})

+ public void testBackgroundOfflinerLaunchBrowserWhenInstanceDoesNotExist() {

dougarnett 2016/06/02 00:14:45 Does this method name apply? Instance of what?

Pete Williamson 2016/06/02 00:42:06 In this case, the instance is of chrome. Notice t

dougarnett 2016/06/02 16:31:47 Yeah, the other examples I looked at were deleting

+ startOnRunTaskAndVerify(OfflinePageUtils.TASK_TAG, true, false, false, false);

+ }

}