Add unit tests for the Background Scheduler.

chrome/browser/android/offline_pages/background_scheduler_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/android/callback_android.h"
 #include "base/android/scoped_java_ref.h"
 #include "chrome/browser/android/offline_pages/background_scheduler_bridge.h"
 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
 #include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_android.h"
 #include "components/offline_pages/background/request_coordinator.h"
 #include "jni/BackgroundSchedulerBridge_jni.h"
 
 using base::android::ScopedJavaGlobalRef;
 
 namespace offline_pages {
 namespace android {
 
 namespace {
 
 // C++ callback that delegates to Java callback.
 void ProcessingDoneCallback(
     const ScopedJavaGlobalRef<jobject>& j_callback_obj, jboolean result) {
-  JNIEnv* env = base::android::AttachCurrentThread();
-  Java_ProcessingDoneCallback_onProcessingDone(
-      env, j_callback_obj.obj(), result);
+  base::android::RunCallbackAndroid(j_callback_obj, result);

[Bernhard Bauer, 2016/06/07 08:43:42]

Wait, does this work when |j_callback_obj| is a ProcessingDoneCallback? I think
you're going to have to actually use org.chromium.base.Callback as the callback
type here.

[Pete Williamson, 2016/06/07 22:04:12]

Ah, good catch.  I was thinking that since the argument and return type
signatures matched that they would get seamlessly mapped, but looking at other
examples shows that isn't so.  I replaced the Java side ProcessingDoneCallback
completely with Callback<Boolean>

 }
 
 }  // namespace
 
 // JNI call to start request processing.
 static jboolean StartProcessing(
     JNIEnv* env,
     const JavaParamRef<jclass>& jcaller,
     const JavaParamRef<jobject>& j_callback_obj) {
   ScopedJavaGlobalRef<jobject> j_callback_ref;
@@ skipping 15 matching lines @@
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_BackgroundSchedulerBridge_unschedule(env);
 }
 
 bool RegisterBackgroundSchedulerBridge(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 }  // namespace offline_pages