Fix finally clause inlining for forward jumps

Fix finally clause inlining for forward jumps

In switch statements, ‘continue L’ jumps can refer to a label
that the compiler hasn’t seen yet. The label is tentatively
to be in the innermost switch statement, but may later
be moved to an outer switch statement. The compiler must
make sure that the correct finally blocks are inlined in front
of these jumps.

BUG=26577, 25310
R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/1859ce46c337e4e047e6543c561ff77af7910074

[hausner, 2016-06-01 23:41:21]

Description was changed from

==========
Fix finally clause inlining for forward jumps

In switch statements, ‘continue L’ jumps can refer to a label
that the compiler hasn’t seen yet. The label is tentatively
to be in the innermost switch statement, but may later
be moved to an outer switch statement. The compiler must
make sure that the correct finally blocks are inlined in front
of these jumps.

BUG=26577
==========

to

==========
Fix finally clause inlining for forward jumps

In switch statements, ‘continue L’ jumps can refer to a label
that the compiler hasn’t seen yet. The label is tentatively
to be in the innermost switch statement, but may later
be moved to an outer switch statement. The compiler must
make sure that the correct finally blocks are inlined in front
of these jumps.

BUG=26577
==========

[hausner, 2016-06-01 23:41:21]

hausner@google.com changed reviewers:
+ regis@google.com

[hausner, 2016-06-01 23:50:01]

Description was changed from

==========
Fix finally clause inlining for forward jumps

In switch statements, ‘continue L’ jumps can refer to a label
that the compiler hasn’t seen yet. The label is tentatively
to be in the innermost switch statement, but may later
be moved to an outer switch statement. The compiler must
make sure that the correct finally blocks are inlined in front
of these jumps.

BUG=26577
==========

to

==========
Fix finally clause inlining for forward jumps

In switch statements, ‘continue L’ jumps can refer to a label
that the compiler hasn’t seen yet. The label is tentatively
to be in the innermost switch statement, but may later
be moved to an outer switch statement. The compiler must
make sure that the correct finally blocks are inlined in front
of these jumps.

BUG=26577, 25310
==========

[regis, 2016-06-02 01:13:25]

LGTM except for a loop that does not look right.

https://codereview.chromium.org/2030763002/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2030763002/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:401: inlined_finally_nodes_[i] = inlined_finally_nodes_[j];
Did you mean j-1 instead of i, which is not incremented?

[hausner, 2016-06-02 15:38:51]

https://codereview.chromium.org/2030763002/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2030763002/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:401: inlined_finally_nodes_[i] = inlined_finally_nodes_[j];
On 2016/06/02 01:13:25, regis wrote:
> Did you mean j-1 instead of i, which is not incremented?

Ahem, yes. Good catch, thank you!

[hausner, 2016-06-02 16:03:52]

Description was changed from

==========
Fix finally clause inlining for forward jumps

In switch statements, ‘continue L’ jumps can refer to a label
that the compiler hasn’t seen yet. The label is tentatively
to be in the innermost switch statement, but may later
be moved to an outer switch statement. The compiler must
make sure that the correct finally blocks are inlined in front
of these jumps.

BUG=26577, 25310
==========

to

==========
Fix finally clause inlining for forward jumps

In switch statements, ‘continue L’ jumps can refer to a label
that the compiler hasn’t seen yet. The label is tentatively
to be in the innermost switch statement, but may later
be moved to an outer switch statement. The compiler must
make sure that the correct finally blocks are inlined in front
of these jumps.

BUG=26577, 25310
R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1859ce46c337e4e047e6543c561ff77af7910074
==========

[hausner, 2016-06-02 16:03:54]

Committed patchset #3 (id:40001) manually as
1859ce46c337e4e047e6543c561ff77af7910074 (presubmit successful).