Fix the Linux shared build.

Fix the Linux shared build.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26291

[Lei Zhang, 2009-09-15 20:55:08]

Broken as always, sigh.

[Evan Martin, 2009-09-15 20:59:14]

mostly good, but i think the gtk deps may be wrong

http://codereview.chromium.org/203076/diff/1/9
File chrome/chrome.gyp (right):

http://codereview.chromium.org/203076/diff/1/9#newcode2271
Line 2271: }],
Wre these tabs? We need to have a stern talking-to with the chromeos people.

http://codereview.chromium.org/203076/diff/1/8
File courgette/courgette.gyp (right):

http://codereview.chromium.org/203076/diff/1/8#newcode99
Line 99: 'dependencies': [
weird tabbing

http://codereview.chromium.org/203076/diff/1/8#newcode103
Line 103: '../build/linux/system.gyp:gtk',
this should be handled using export_dependent_settings in base, then

http://codereview.chromium.org/203076/diff/1/7
File printing/printing.gyp (right):

http://codereview.chromium.org/203076/diff/1/7#newcode72
Line 72: 'dependencies': [
weird tabbing

http://codereview.chromium.org/203076/diff/1/3
File third_party/libevent/libevent.gyp (right):

http://codereview.chromium.org/203076/diff/1/3#newcode41
Line 41: 'sources': [ 'epoll.c', 'epoll_sub.c' ],
weird tabbing

http://codereview.chromium.org/203076/diff/1/3#newcode47
Line 47: '-lrt',
doesn't common.gypi cover this?

http://codereview.chromium.org/203076/diff/1/4
File third_party/libxml/libxml.gyp (right):

http://codereview.chromium.org/203076/diff/1/4#newcode181
Line 181: '-ldl',
libxml calls dlopen?

[Lei Zhang, 2009-09-15 22:22:27]

http://codereview.chromium.org/203076/diff/1/9
File chrome/chrome.gyp (right):

http://codereview.chromium.org/203076/diff/1/9#newcode2271
Line 2271: }],
On 2009/09/15 20:59:14, Evan Martin wrote:
> Wre these tabs? We need to have a stern talking-to with the chromeos people.

Yes, lots of tabs.

http://codereview.chromium.org/203076/diff/1/8
File courgette/courgette.gyp (right):

http://codereview.chromium.org/203076/diff/1/8#newcode99
Line 99: 'dependencies': [
On 2009/09/15 20:59:14, Evan Martin wrote:
> weird tabbing

Fixed.

http://codereview.chromium.org/203076/diff/1/8#newcode103
Line 103: '../build/linux/system.gyp:gtk',
On 2009/09/15 20:59:14, Evan Martin wrote:
> this should be handled using export_dependent_settings in base, then

It doesn't work, this is a workaround for gyp bug 69.

http://codereview.chromium.org/203076/diff/1/7
File printing/printing.gyp (right):

http://codereview.chromium.org/203076/diff/1/7#newcode72
Line 72: 'dependencies': [
On 2009/09/15 20:59:14, Evan Martin wrote:
> weird tabbing

Fixed.

http://codereview.chromium.org/203076/diff/1/3
File third_party/libevent/libevent.gyp (right):

http://codereview.chromium.org/203076/diff/1/3#newcode41
Line 41: 'sources': [ 'epoll.c', 'epoll_sub.c' ],
On 2009/09/15 20:59:14, Evan Martin wrote:
> weird tabbing

Fixed.

http://codereview.chromium.org/203076/diff/1/3#newcode47
Line 47: '-lrt',
On 2009/09/15 20:59:14, Evan Martin wrote:
> doesn't common.gypi cover this?

cover -lrt? err?

http://codereview.chromium.org/203076/diff/1/4
File third_party/libxml/libxml.gyp (right):

http://codereview.chromium.org/203076/diff/1/4#newcode181
Line 181: '-ldl',
On 2009/09/15 20:59:14, Evan Martin wrote:
> libxml calls dlopen?

Yes, in xmlmodule.c

[Evan Martin, 2009-09-15 22:26:45]

Since all my other complaints were whitespace, LGTM rubber stamp.  :)

http://codereview.chromium.org/203076/diff/1/8
File courgette/courgette.gyp (right):

http://codereview.chromium.org/203076/diff/1/8#newcode103
Line 103: '../build/linux/system.gyp:gtk',
On 2009/09/15 22:22:27, Lei Zhang wrote:
> On 2009/09/15 20:59:14, Evan Martin wrote:
> > this should be handled using export_dependent_settings in base, then
> 
> It doesn't work, this is a workaround for gyp bug 69.

Can you mention that bug in the comment here and below?  (That way later someone
can just consult the BTS to see if it's fixed)

[TVL, 2009-09-16 14:58:41]

http://codereview.chromium.org/203076/diff/5001/6005
File third_party/ffmpeg/ffmpeg.gyp (right):

http://codereview.chromium.org/203076/diff/5001/6005#newcode154
Line 154: '-ldl',
this is making the mac build grumpy, you needed conditionals in here