Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 203073007: Add a switch to control which CLD2 tables are used at build time. (Closed)

Created:
6 years, 9 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, dsites_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a switch to control which CLD2 tables are used at build time. Mobile platforms have traditionally opted for smaller binaries. These options allow mobile platforms some flexibility in trading language detection accuracy for binary size. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M build/common.gypi View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/cld_2/cld_2.gyp View 3 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Andrew Hayden (chromium.org)
PTAL.
6 years, 9 months ago (2014-03-18 14:26:28 UTC) #1
Takashi Toyoshima
LGTM
6 years, 9 months ago (2014-03-19 02:19:08 UTC) #2
hajimehoshi
Thanks, lgtm
6 years, 9 months ago (2014-03-19 04:08:56 UTC) #3
Andrew Hayden (chromium.org)
CCing Dick as fyi. Thanks, guys. I'll get this committed and rebase the data file ...
6 years, 9 months ago (2014-03-19 05:52:08 UTC) #4
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 9 months ago (2014-03-19 05:52:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/203073007/1
6 years, 9 months ago (2014-03-19 05:52:57 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 07:17:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-19 07:17:17 UTC) #8
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 9 months ago (2014-03-19 07:54:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/203073007/1
6 years, 9 months ago (2014-03-19 07:54:38 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 12:11:06 UTC) #11
Message was sent while issue was closed.
Change committed as 257949

Powered by Google App Engine
This is Rietveld 408576698