Issue 203073006: Change the way instrumented libraries are built.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203073006: Change the way instrumented libraries are built. (Closed)

Created:
6 years, 9 months ago by earthdok

Modified:
6 years, 9 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Change the way instrumented libraries are built. Instead of passing --prefix to the configure script, we now pass DESTDIR to make. This allows the instrumented libraries to access system-wide configuration. BUG=313751 R=glider@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257783

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -14 lines)			Patch
M	third_party/instrumented_libraries/download_build_install.py	View		3 chunks	+29 lines, -10 lines	0 comments	Download
M	third_party/instrumented_libraries/instrumented_libraries.gyp	View	1	6 chunks	+16 lines, -4 lines	0 comments	Download
M	third_party/instrumented_libraries/standard_instrumented_library_target.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/203073006/20001

6 years, 9 months ago (2014-03-18 20:52:04 UTC) #4

Message was sent while issue was closed.

Change committed as 257783