Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 203073003: Use of validating IPC enum macros for quota messages (Closed)

Created:
6 years, 9 months ago by anish.p
Modified:
6 years, 9 months ago
Reviewers:
Tom Sepez, michaeln
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use of validating IPC enum macros for quota messages This is part of long-running background task to remove remaining uses of the unchecked IPC_ENUM_TRAITS() macro BUG=246708 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/quota_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/quota/quota_types.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
anish.p
I am on CLA. So, I can contribute. Is it alright to validate quota message ...
6 years, 9 months ago (2014-03-18 10:23:28 UTC) #1
Tom Sepez
LGTM. You'll also need an LGTM from someone listed in the webkit/OWNERS file for quota_types.h ...
6 years, 9 months ago (2014-03-18 16:58:23 UTC) #2
michaeln
lgtm
6 years, 9 months ago (2014-03-24 19:52:41 UTC) #3
anish.p
The CQ bit was checked by anish.p@samsung.com
6 years, 9 months ago (2014-03-25 03:37:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anish.p@samsung.com/203073003/1
6 years, 9 months ago (2014-03-25 03:42:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 05:03:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-25 05:03:24 UTC) #7
anish.p
The CQ bit was checked by anish.p@samsung.com
6 years, 9 months ago (2014-03-25 05:24:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anish.p@samsung.com/203073003/1
6 years, 9 months ago (2014-03-25 05:24:12 UTC) #9
anish.p
The CQ bit was unchecked by anish.p@samsung.com
6 years, 9 months ago (2014-03-25 05:24:18 UTC) #10
anish.p
The CQ bit was checked by anish.p@samsung.com
6 years, 9 months ago (2014-03-25 05:24:19 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 07:07:17 UTC) #12
Message was sent while issue was closed.
Change committed as 259170

Powered by Google App Engine
This is Rietveld 408576698