Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 203073002: Rename |imp| => |impl| in wtf (one use) (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium
Visibility:
Public.

Description

Rename |imp| => |impl| in wtf (one use) This is the last inconsistent use of |imp| instead of |impl| in Chromium C++. (There are a few Objective C++ uses that I'm not touching.) Followup to Rename |imp| => |impl| in bindings generation https://codereview.chromium.org/202203009/ TBR=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/wtf/text/AtomicString.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
Clean-up.
6 years, 9 months ago (2014-03-18 05:03:14 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-18 05:03:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/203073002/1
6 years, 9 months ago (2014-03-18 05:03:25 UTC) #3
commit-bot: I haz the power
Change committed as 169415
6 years, 9 months ago (2014-03-18 06:07:03 UTC) #4
haraken
LGTM (but I'm not an OWNER of wtf/)
6 years, 9 months ago (2014-03-18 06:36:33 UTC) #5
Nils Barth (inactive)
abarth: TBR?
6 years, 9 months ago (2014-03-19 01:42:45 UTC) #6
abarth-chromium
6 years, 9 months ago (2014-03-19 17:05:47 UTC) #7
Message was sent while issue was closed.
LGTM :)

Powered by Google App Engine
This is Rietveld 408576698