Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2030713005: Revert of re-enable PCv2 on non-ref Android (Closed)

Created:
4 years, 6 months ago by Zhen Wang
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of re-enable PCv2 on non-ref Android (patchset #1 id:1 of https://codereview.chromium.org/2030523003/ ) Reason for revert: page_cycler_v2.typical_25 fails on Android perf bot. See http://crbug.com/616781 Original issue's description: > re-enable PCv2 on non-ref Android > > BUG=615178 > > Committed: https://crrev.com/b34eeae48ba79e80c4ec601922459d77af905f5a > Cr-Commit-Position: refs/heads/master@{#397120} TBR=nednguyen@google.com,kouhei@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=615178

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M tools/perf/benchmarks/page_cycler_v2.py View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Zhen Wang
Created Revert of re-enable PCv2 on non-ref Android
4 years, 6 months ago (2016-06-03 01:42:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030713005/1
4 years, 6 months ago (2016-06-03 01:43:16 UTC) #3
nednguyen
On 2016/06/03 01:43:16, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 6 months ago (2016-06-03 01:49:38 UTC) #5
Zhen Wang
On 2016/06/03 01:49:38, nednguyen wrote: > On 2016/06/03 01:43:16, commit-bot: I haz the power wrote: ...
4 years, 6 months ago (2016-06-03 01:51:00 UTC) #6
Zhen Wang
On 2016/06/03 01:51:00, Zhen Wang wrote: > On 2016/06/03 01:49:38, nednguyen wrote: > > On ...
4 years, 6 months ago (2016-06-03 01:53:23 UTC) #7
nednguyen
On 2016/06/03 01:51:00, Zhen Wang wrote: > On 2016/06/03 01:49:38, nednguyen wrote: > > On ...
4 years, 6 months ago (2016-06-03 01:54:52 UTC) #8
Zhen Wang
> I mean the flaky failures are not on all android bots, just "Android Nexus5X ...
4 years, 6 months ago (2016-06-03 01:59:23 UTC) #9
nednguyen
On 2016/06/03 01:59:23, Zhen Wang wrote: > > I mean the flaky failures are not ...
4 years, 6 months ago (2016-06-03 02:36:39 UTC) #10
nednguyen
>> I see in the bug that the failure > > test does not have ...
4 years, 6 months ago (2016-06-03 02:37:45 UTC) #11
Zhen Wang
4 years, 6 months ago (2016-06-03 06:41:33 UTC) #12
Based on the discussion with Ned, we decided to disable the test on Android One
and Nexus 5X only, and not revert the original CL.

Closing this CL without commit now. See
https://codereview.chromium.org/2030243003/

Powered by Google App Engine
This is Rietveld 408576698