scripts/slave/recipe_modules/chromium_android/chromium_config.py - Issue 2030713004: Refactor chromium.perf recipe configs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_android/chromium_config.py

Issue 2030713004: Refactor chromium.perf recipe configs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@2-refactorr

Patch Set: Rebase, hope it's right :) Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium_android/chromium_config.py

diff --git a/scripts/slave/recipe_modules/chromium_android/chromium_config.py b/scripts/slave/recipe_modules/chromium_android/chromium_config.py

index 39c097500b50afc94006d746f39ef1da454b036d..4ea41fe546603067633856653170290cecb007cf 100644

--- a/scripts/slave/recipe_modules/chromium_android/chromium_config.py

+++ b/scripts/slave/recipe_modules/chromium_android/chromium_config.py

@@ -197,14 +197,6 @@ def incremental_coverage_builder_tests(c):

def non_device_wipe_provisioning(c):

pass

-# TODO(zty): figure out what perf builder really wants and use that instead.

-# e.g. official

-@CONFIG_CTX(includes=['main_builder'])

-def perf(c):

- gyp_defs = c.gyp_env.GYP_DEFINES

- gyp_defs['branding'] = 'Chrome'

- gyp_defs['buildtype'] = 'Official'

@CONFIG_CTX(includes=['main_builder'])

def cast_builder(c):

c.gyp_env.GYP_DEFINES['chromecast'] = 1

« no previous file with comments | « scripts/slave/recipe_modules/chromium/config.py ('k') | scripts/slave/recipe_modules/chromium_android/config.py » ('j') | no next file with comments »